Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[506] update provider report to reflect new withdrawal reasons #10220

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[506] update provider report to reflect new withdrawal reasons #10220

wants to merge 3 commits into from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 7, 2025 •
edited
Loading

Context

Trello card: https://trello.com/c/5zAe8jNi

We have updated the withdrawal reasons a candidate can give and made them mandatory.

We need to update the provider report on withdrawal reasons to reflect these changes.

Because we have made this change part way through the cycle, we need to keep two reports active for the rest of the cycle. The one reflecting the old style of withdrawal reasons and this new one which reflect the changes.

Changes proposed in this pull request

withdrawal.reasons.report.mov

Guidance to review

Login as support user Susan Upport in the review app.
Navigate to Reports -> Withdrawal reports
Select the various reports and make sure you see the data as expected.

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee self-assigned this Jan 7, 2025
@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Jan 7, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 7, 2025 16:59 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 7, 2025 17:30 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 49a879a to 43d96ef Compare January 8, 2025 08:50
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 08:55 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 43d96ef to d916687 Compare January 8, 2025 09:07
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 09:12 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from d916687 to 68ee62c Compare January 8, 2025 09:52
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 09:57 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 68ee62c to 33305e8 Compare January 8, 2025 11:19
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 11:24 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 8937329 to 4fc05d9 Compare January 8, 2025 16:43
@elceebee elceebee changed the title 506 update provider report to reflect new withdrawal reasons [506] update provider report to reflect new withdrawal reasons Jan 8, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 16:48 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 17:04 Destroyed
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 4fc05d9 to a14e14b Compare January 8, 2025 17:27
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 8, 2025 17:33 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 9, 2025 09:16 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 9, 2025 09:31 Destroyed
elceebee
elceebee commented Jan 9, 2025
View reviewed changes
app/helpers/navigation_items.rb
@@ -77,7 +77,7 @@ def for_provider_primary_nav(current_provider_user, current_controller, performi
if current_provider_user && !performing_setup
items << NavigationItem.new('Applications', provider_interface_applications_path, active?(current_controller, %w[application_choices decisions offer_changes notes interviews offers feedback conditions reconfirm_deferred_offers]), [])
items << NavigationItem.new('Interview schedule', provider_interface_interview_schedule_path, active?(current_controller, %w[interview_schedules]), [])
items << NavigationItem.new('Reports', provider_interface_reports_path, active?(current_controller, %w[reports application_data_export hesa_export recruitment_performance_reports]))
items << NavigationItem.new('Reports', provider_interface_reports_path, active?(current_controller, %w[reports application_data_export hesa_exports recruitment_performance_reports withdrawal_reports withdrawal_reasons_reports status_of_active_applications diversity_reports]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the navigation for all the reports -- it was only showing as highlighted for hesa and recruitment performance. Now it is highlighted for all the reports on the page.

elceebee
elceebee commented Jan 9, 2025
View reviewed changes
...provider_interface/reports/index_provider_user_two_providers_with_performance_report_spec.rb
scenario 'when provider user has multiple provider with performance report', time: mid_cycle(2024) do
given_a_provider_user_with_two_providers_exists
and_a_provider_has_a_recruitment_peroformance_report
and_a_provider_has_a_recruitment_performance_report
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing a typo peroformance

@elceebee elceebee marked this pull request as ready for review January 9, 2025 09:46
@elceebee elceebee requested a review from a team January 9, 2025 09:47
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 8b0706c to 830d27f Compare January 9, 2025 09:58
@github-actions github-actions bot temporarily deployed to review_aks-10220 January 9, 2025 10:02 Destroyed
dcyoung-dev
dcyoung-dev approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece of work 👌

app/services/provider_interface/candidate_withdrawal_reasons_data_by_provider.rb Outdated Show resolved Hide resolved
@elceebee elceebee force-pushed the 506-update-provider-report-to-reflect-new-withdrawal-reasons branch from 830d27f to 99dc075 Compare January 9, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcyoung-dev dcyoung-dev dcyoung-dev approved these changes

Assignees

@elceebee elceebee

Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elceebee @dcyoung-dev