Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Account Recovery Request Code #10224

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Jan 8, 2025

Context

We need to use has_secure_password for the code on the Account Recovery Request Code. To use this helper, you need to have a xxx_digest column in DB.

This commit creates this column. There are no records in any environment for this table, using safety assured should be enough.

Changes proposed in this pull request

Migration to create code_digest column on AccountRecoveryRequestCode

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

We need to use has_secure_password for the code on the Account Recovery
Request Code. To use this helper, you need to have a xxx_digest column
in DB.

This commit creates this column. There are no records in any environment
for this table, using safety assured should be enough.
@CatalinVoineag CatalinVoineag marked this pull request as ready for review January 8, 2025 13:10
@CatalinVoineag CatalinVoineag self-assigned this Jan 8, 2025
@CatalinVoineag CatalinVoineag added the deploy_v2 Deploy the review app to AKS label Jan 8, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10224 January 8, 2025 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-10224 January 8, 2025 13:45 Destroyed
Copy link
Collaborator

@dcyoung-dev dcyoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we've not deployed any of the Account Recovery candidate flow work?

@CatalinVoineag
Copy link
Contributor Author

I assume we've not deployed any of the Account Recovery candidate flow work?

This needs to go first

@CatalinVoineag CatalinVoineag merged commit edf9fae into main Jan 8, 2025
46 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/rename_account_recovery_request_column branch January 8, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants