Update provider reports #8616
Merged
Update provider reports #8616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only write to submitted_at on the first application choice submission. A candidate can have numerous submissions, but the submitted_at value will not change. Therefore we need to use sent_to_provider_at on the application choice.
JR-G
force-pushed
the
update-provider-reports
branch
from
9467dfb to
8588c14
Compare
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/system/provider_interface/provider_changes_conditions_on_an_offer_spec.rb:8: |
tomas-stefano
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Code wise looks good 🚀. Because of our limited dev time this week and next, can someone else take a look on the data generated is correct from the PR? I am not sure if @MylesJarvis or @DFE-Digital/find-and-apply-designers are the best to review those. Let me know ✌️
|
I've requested a deploy to a preview app, but I'm not sure whether the generated data will be good enough to test everything. I'll report back. |
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/services/duplicate_application_spec.rb:122: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On the Provider interface on Manage, we offer providers a number of reports that they can view. We need to update these to ensure they will still work with continuous applications.
Changes proposed in this pull request
sent_to_provider_at, not application forms bysubmitted_atGuidance to review
Link to Trello card
https://trello.com/c/sUdWd9Z5/28-ca-review-and-update-any-required-provider-reports-on-manage
Things to check