Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to AcceptOffer and withdrawal processes #8631

Closed
wants to merge 7 commits into from

Conversation

inulty-dfe
Copy link
Collaborator

Context

Some code refactorings and updates odne while investigating a ticket relating to withdraw emails.

Changes proposed in this pull request

  • Add inactive status to DECISION_PENDING statuses.
  • Extend test for sibling status updates when an offer is accepted
  • remove candidate_ prefix from some test file names
  • iterate over referrence feedback in ruby rather than through scope so build_stubbed records are shown in the email previews

Guidance to review

Link to Trello card

  Create a spec for every possible status showing how the status is
  changed when a sibling is choice offer is accepted
  enumerate each expected status change for sibling application choices
  when a candidate accepts one of the offers
@inulty-dfe
Copy link
Collaborator Author

Separate tickets now exist for the changes proposed in this PR

@inulty-dfe inulty-dfe closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant