Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the personal statement inset text #8633

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Oct 4, 2023

Context

After a candidate has submitted an application choice we allow them to change their personal statement for future applications.

We need to render guidance to inform them that this change will not apply to previous application choices.

Changes proposed in this pull request

Before After
image image

Guidance to review

  • Check the personal statement section – there should be no inset text
  • Submit an application
  • View the personal statement section again – personal statement specific text should appear
  • Check other sections – should be the standard inset text

Link to Trello card

https://trello.com/c/u6JRkHFn/737-apply-missing-inset-when-editing-a-personal-statement-post-submission

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

After a candidate has submitted an application choice we allow
them to change their personal statement for the next one. We need
to render guidance to inform them that this change will not apply
to previous application choices.
@JR-G JR-G added deploy_v2 Deploy the review app to AKS Continuous applications Work relating to continuous applications labels Oct 4, 2023
@github-actions github-actions bot temporarily deployed to review_aks-8633 October 4, 2023 20:56 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 4, 2023 20:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Code Coverage

Coverage typeFromTo
⬇️Lines covered95.64%95.1%

@github-actions github-actions bot temporarily deployed to review_aks-8633 October 4, 2023 21:14 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 4, 2023 21:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Code Coverage

Coverage typeFromTo
⬇️Lines covered95.64%95.32%

@JR-G JR-G requested a review from a team October 5, 2023 06:07
Copy link
Contributor

@Kateharries Kateharries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ideally it would be nice if all of this content was on one line. I had a few thoughts of how to change it but it ended up not being as clear as what's already there. We could try contracting the 'you have' to 'you've' @MaeveRoseveare ? This is no biggie though, and could just be something to return to :)

@JR-G JR-G merged commit 0b0db32 into main Oct 5, 2023
180 checks passed
@JR-G JR-G deleted the update-the-personal-statement-inset-text branch October 5, 2023 08:25
@JR-G JR-G temporarily deployed to review_aks October 5, 2023 08:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Continuous applications Work relating to continuous applications deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants