Fix apply again bug on continuous applications #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user is in conditions_not_met, after login it is rendered
the complete page.
We shouldn't never render the complete page whenever the status
so I decided to write a system spec to guarantee that whenever is
the status we never render the complete page (only for continous
applications!).
tomas-stefano
added
deploy_v2
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
You have one or more flakey tests on this branch! ❄️ ❄️ ❄️Failed 1 out of 3 times at ./spec/forms/candidate_interface/pick_course_form_spec.rb:75:(compared using eql?) �[37mDiff:�[0m �[34m┌ (Key) ──────────────────────────┐�[0m [ |
Code Coverage
|
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
inulty-dfe
approved these changes
Oct 5, 2023
MaeveRoseveare
approved these changes
Oct 5, 2023
Code Coverage
|
tomas-stefano
deleted the
732-apply-candidates-incorrectly-able-to-enter-apply-again-status
branch
tomas-stefano
temporarily deployed
to
review_aks
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the user is in conditions_not_met, after login it is rendered the complete page.
The problem with this page that on this page the user can "apply again" and create a new application form and bypass any cap that we have.
We shouldn't never render the complete page whenever the status so I decided to write a system spec to guarantee that whenever is the status we never render the complete page (only for continuous applications!).
Guidance to review
On conditions not met, does it redirect to the right place?
Link to Trello card
https://trello.com/c/ohrxOhLE/732-apply-candidates-incorrectly-able-to-enter-apply-again-status