Manage: Identify and remove all instances of "Automatic Rejections" #8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarembas
force-pushed
the
714-manage-instances-of-automatic-rejections
branch
from
3b246dc to
2a01424
Compare
JR-G
reviewed
Oct 9, 2023
| @@ -2,9 +2,5 @@ | |||
| Waiting for candidate’s response | |||
| </h2> | |||
| <p class="govuk-body"> | |||
| <% if application_choice.continuous_applications? %> | |||
| <%= continuous_applications_offer_text %> | |||
| <% else %> | |||
There was a problem hiding this comment.
We still have some candidates with offers for 2023 – they have till ~12th oct until DBD
There was a problem hiding this comment.
Done in f33140e. Added it as a separate commit as we can re-revert it later.
JR-G
reviewed
Oct 9, 2023
There was a problem hiding this comment.
I noticed that when I logged in as a provider user without the permissions to make decisions, I saw this text on a received application, still mentioning reject by default:
When I changed the permissions to being able to make decisions, the text changed to the new one where we do not mention RBD.
This is the same for 'Interviewing' status:
This commit addresses a few scenarios where we were displaying information related to reject by default date. It also adds a concern to the ApplicationChoice model to help with the date calculations.
This is for candidates with offers for 2023, they have till ~12th oct until declined by default.
zarembas
force-pushed
the
714-manage-instances-of-automatic-rejections
branch
from
2a01424 to
f33140e
Compare
Code Coverage
|
JR-G
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a few scenarios where we were displaying information related to reject by default date.
It also adds a concern to the
ApplicationChoicemodel to help with the date calculations.Changes proposed in this pull request
Header ‘Ready for review’ change to: ‘Received – make a decision’
Content below purple ‘Received' status change to: Received [36] days ago
Content below green ‘Offered’ status change to: Offer made [53] days ago
Content below yellow ‘Interviewing’ status change to: Received [36] days ago
Set up an interview or make a decision inset text within an application, change to: This application was received 80 days ago. You should try and respond to the candidate within 30 days.
After an offer has been made inset text within an application, change to: You made this offer [10] days ago. Most candidates respond to offers within 15 working days. The candidate will receive reminders to respond.
Date of the interview, remove validation for setting a date within 40 working days.
Remove inset text of Date field and change to: For example, 30 11 2023
Guidance to review
They way I'm handling the
days_sincemethods might not be to everyone's taste. Happy to change based on feedback.Link to Trello card
https://trello.com/c/vaRJnjiz/714-manage-identify-and-remove-all-instances-of-automatic-rejections