Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recruit with pending conditions status tags #8665

Conversation

stevehook
Copy link
Collaborator

@stevehook stevehook commented Oct 11, 2023

Context

It would be beneficial to SCITT providers if we allowed them to move a candidate who was only pending SKE conditions to ‘Recruited’ as this would automatically import their record into Register saving them from having to manually create it. This is particularly useful for providers (and DfE) who are busy getting their ITT data ready for the ITT census deadline in October.

We have a PR (#8650) to implement the basics of this feature (mainly the forms in Manage that enable a provider to recruit a candidate despite them having a pending SKE condition). This PR builds upon that work by adding an additional status 'tag' for recruited applications that still have SKE conditions pending so that providers, support and the candidates themselves can all see at a glance that this is the case.

Changes proposed in this pull request

The various ApplicationStatusTagComponent classes all need to be rendered with an additional SKE pending conditions label when the application in question is in the recruited state but has one or more pending SKE conditions.

Manager

image

image

Support

image

Uploading image.png…

Candidate interface

image

Guidance to review

DRAFT FOR NOW

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch 3 times, most recently from 78f5008 to f54e528 Compare October 12, 2023 17:24
value: render(
ApplicationStatusTagComponent.new(
application_choice:,
supplementary_statuses: supplementary_statuses_for(application_choice:),
Copy link
Collaborator Author

@stevehook stevehook Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts I reckon the handling of supplementary statuses should probably be handled in the component itself rather than passed in. supplementary_statuses_for should probably be a method on the ApplicationChoice model rather than a helper method. Any thoughts?

@stevehook stevehook marked this pull request as ready for review October 13, 2023 09:01
@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch from f54e528 to c42076e Compare October 13, 2023 14:20
Base automatically changed from 6161-recruit-with-pending-conditions-button-on-manage to main October 17, 2023 08:26
The various `ApplicationStatusTagComponent` classes all need to be
rendered with an additional _SKE pending conditions_ label when the
application in question is in the `recruited` state but has one or more
pending SKE conditions.
@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch 3 times, most recently from 7ee2f8d to 55ec3dd Compare October 17, 2023 09:35
@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch from 55ec3dd to 651217c Compare October 17, 2023 09:45
@stevehook stevehook merged commit 34407b5 into main Oct 17, 2023
60 checks passed
@stevehook stevehook deleted the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch October 17, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants