Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey from Find – reapply for previously unsuccessful courses #8666

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Oct 11, 2023

Context

We allow candidates to reapply for courses provided they have been previously unsuccessful with the choice. We need to replicate this for the apply from Find journey.

Changes proposed in this pull request

Only check for courses associated to application choices in the following states:

  • awaiting_provider_decision
  • interviewing
  • pending_conditions
  • conditions_not_met
  • recruited
  • offer
  • offer_deferred
  • inactive
  • unsubmitted
Before After
image image

Guidance to review

Aside from the Find journey, this method appears to only be used in the pre continuous applications course selection journey.

You can test locally with the following URL:
http://localhost:3000/candidate/apply?providerCode=XXX&courseCode=XXXX

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@github-actions
Copy link
Contributor

Code Coverage

Coverage typeFromTo
⬇️Lines covered95.61%95.33%

@JR-G JR-G changed the title Allow candidates to apply for previously unsuccessful courses Journey from Find – reapply for previously unsuccessful courses Oct 11, 2023
@JR-G JR-G force-pushed the apply-from-find-apply-for-previously-unsuccessful branch from 2de262d to fc425d1 Compare October 12, 2023 08:01
@JR-G JR-G requested a review from a team October 12, 2023 08:01
@JR-G JR-G marked this pull request as ready for review October 12, 2023 08:01
@JR-G JR-G added the deploy_v2 Deploy the review app to AKS label Oct 12, 2023
@github-actions github-actions bot temporarily deployed to review_aks-8666 October 12, 2023 08:26 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 12, 2023 08:26 — with GitHub Actions Inactive
We allow candidates to reapply for courses provided they have been
previously unsuccessful with the choice. We need to replicate this
for the apply from Find journey.
@JR-G JR-G force-pushed the apply-from-find-apply-for-previously-unsuccessful branch from fc425d1 to 7680d62 Compare October 12, 2023 08:43
@github-actions github-actions bot temporarily deployed to review_aks-8666 October 12, 2023 08:47 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 12, 2023 08:47 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

You have one or more flakey tests on this branch! ❄️ ❄️ ❄️

Failed 1 out of 3 times at ./spec/services/duplicate_application_spec.rb:122: ⚠️ Expected �[33m0�[0m to eq �[35m1�[0m.

@JR-G JR-G merged commit 356fbcc into main Oct 12, 2023
59 of 60 checks passed
@JR-G JR-G deleted the apply-from-find-apply-for-previously-unsuccessful branch October 12, 2023 10:32
@JR-G JR-G temporarily deployed to review_aks October 12, 2023 10:32 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants