Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inactive application component #8686

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Update inactive application component #8686

merged 6 commits into from
Oct 23, 2023

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Oct 16, 2023 •
edited
Loading

Context

We're not rendering the 'View application' link or the interview content for inactive applications.

Changes proposed in this pull request

The RBD content was causing a handful of tests to fail. Even though RBD is no longer applicable it's out of scope for this PR and needs to be removed as part of the clean up & review.

The 'View application' link wouldn't render if the course was full.

Before After
image image

Guidance to review

Link to Trello card

https://trello.com/c/WqVfkeUV/744-apply-render-interviews-row-for-inactive-applications
https://trello.com/c/Ywmrn8yU/789-apply-render-view-application-link-on-inactive-applications

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@JR-G JR-G added deploy_v2 Deploy the review app to AKS Continuous applications Work relating to continuous applications labels Oct 16, 2023
@JR-G JR-G requested a review from a team October 16, 2023 13:08
@JR-G JR-G marked this pull request as ready for review October 16, 2023 13:12
@JR-G JR-G force-pushed the update-inactive-application-component branch from 6d26ecd to b072826 Compare October 16, 2023 13:34
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 16, 2023 13:39 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 16, 2023 13:39 — with GitHub Actions Inactive
@JR-G JR-G force-pushed the update-inactive-application-component branch from b072826 to eac5df4 Compare October 16, 2023 14:12
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 16, 2023 14:16 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 16, 2023 14:16 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 16, 2023 16:35 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 16, 2023 16:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 17, 2023 07:07 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 17, 2023 07:07 — with GitHub Actions Inactive
zarembas
zarembas reviewed Oct 17, 2023
View reviewed changes
spec/models/application_choice_spec.rb Outdated
@@ -57,7 +57,7 @@

describe '#decision_pending?' do
it 'returns false for choices in states not requiring provider action' do
(ApplicationStateChange.valid_states - ApplicationStateChange::DECISION_PENDING_STATUSES).each do |state|
(ApplicationStateChange.valid_states - ApplicationStateChange::DECISION_PENDING_STATUSES - %i[inactive]).each do |state|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@JR-G JR-G force-pushed the update-inactive-application-component branch from 3ac599a to 09d815e Compare October 17, 2023 12:42
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 17, 2023 12:46 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 17, 2023 12:46 — with GitHub Actions Inactive
inulty-dfe
inulty-dfe approved these changes Oct 20, 2023
View reviewed changes
app/models/application_choice.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to review_aks-8686 October 23, 2023 07:22 Destroyed
@JR-G JR-G temporarily deployed to review_aks October 23, 2023 07:22 — with GitHub Actions Inactive
@JR-G JR-G merged commit b431f56 into main Oct 23, 2023
60 checks passed
@JR-G JR-G deleted the update-inactive-application-component branch October 23, 2023 07:56
@JR-G JR-G temporarily deployed to review_aks October 23, 2023 07:56 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaeveRoseveare MaeveRoseveare MaeveRoseveare left review comments

@zarembas zarembas zarembas left review comments

@duncanjbrown duncanjbrown duncanjbrown left review comments

@inulty-dfe inulty-dfe inulty-dfe approved these changes

Assignees
No one assigned
Labels
Continuous applications Work relating to continuous applications deploy_v2 Deploy the review app to AKS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JR-G @duncanjbrown @zarembas @MaeveRoseveare @inulty-dfe