Highlight candidate application edits on manage (with activity log fix) #8706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
changed the title
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
4a71de2 to
5af3a24
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
5af3a24 to
359cc44
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
359cc44 to
9a1b9f8
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
9a1b9f8 to
2bbb8b7
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
2bbb8b7 to
680aaff
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
f03248f to
b0c0d30
Compare
| user = event.user_full_name | ||
| candidate = event.candidate_full_name | ||
|
|
||
| case event.application_status_at_event |
There was a problem hiding this comment.
Can we do something similar like:
t("provider_interface.activity_log.application_choice.#{event_name}")
And then on event_name we could do:
def event_name
return event.application_status_at_event if event.application_status_at_event.in?(application_status_list)
# changes attribute ...
end
There was a problem hiding this comment.
Not sure I've implemented it the way you described but I've made it less painful to look at and hopefully easier to understand. Translations included
app/components/provider_interface/activity_log/application_form.rb
Outdated
Show resolved
Hide resolved
MaeveRoseveare
approved these changes
Oct 23, 2023
This reverts commit eff059b.
Mapping accepts a list of sections and returns the relevant database columns for `.by_section' Mapping accepts a list of database columns and returns a list of corresponding sections for `.by_columns`
Some Audits cannot store a reference to an application choice. We must return the application choice id from the join when we query. When the query returns Audits for ApplicationForm, we only want to return those Audits whose audit_changes are a subset of a whitelist of columns. The app is only tracking audits where personal_information, contact_information, disability_disclosure and interview_preferences are changed.
Polymorphise `ActivityLog#event_description` to handle all possible Autids
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
b0c0d30 to
c96e21d
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
c96e21d to
b741cbe
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
from
42f441d to
134465a
Compare
inulty-dfe
deleted the
33-ca-highlight-candidate-application-edits-on-manage-with-activity-log-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Un reverts #8695
Additional changes can be inspected from b0b2e61
ActivityLog in the provider interface collates all audits on applications for the current provider. This query requires access to the application choice. Audits that are created because an application form changes do not have a direct relationship to an application choice so the view logic has no way of generating a link to the relevant application choice.
Screenshots
Changes proposed in this pull request
Here we update the
ActivityLogquery to return theapplication_choice_idcolumn. We can access this when theAudit#auditableorAudit#associatedis not anApplicationChoiceAlso added is
ApplicationForm::ColumnSectionMapping.This provides a simple API for getting the columns belonging to a section, and getting the section that a column belongs to.
Guidance to review
Have I collected all the correct columns corresponding to the sections?
Link to Trello card
Trello Ticket