Also check for applications that have exceeded the unsuccessful cap #8708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We reduced the unsuccessful cap from 20 to 15. It appears that before we did this a candidate managed to exceed 15 and since the logic is only checking for an exact match (on the assumption no one would be able to reach beyond this point) they are getting picked up by our invariant check.
Changes proposed in this pull request
rather than
count == cap
we will now docount >= cap
Guidance to review
Link to Trello card
Things to check