Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also check for applications that have exceeded the unsuccessful cap #8708

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Oct 20, 2023

Context

We reduced the unsuccessful cap from 20 to 15. It appears that before we did this a candidate managed to exceed 15 and since the logic is only checking for an exact match (on the assumption no one would be able to reach beyond this point) they are getting picked up by our invariant check.

Changes proposed in this pull request

rather than count == cap we will now do count >= cap

Guidance to review

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@JR-G JR-G requested a review from a team October 20, 2023 09:00
@JR-G JR-G merged commit f92f855 into main Oct 20, 2023
60 checks passed
@JR-G JR-G deleted the amend-unsuccessful-cap-check branch October 20, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants