Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag the editable unlock tool #8776

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

JR-G
Copy link
Contributor

@JR-G JR-G commented Nov 14, 2023

Context

As part of #8722 we introduced a new feature that allows support agents to grant candidates the ability to edit sections of their application form after submission.

We want to tightly control the use of this and require that policy signs it off.

Changes proposed in this pull request

  • Add a permanent feature flag
  • Add a mandatory checkbox:
image

Guidance to review

  • Switch the FF on and off
  • Try submitting without the checkbox ticked

Link to Trello card

https://trello.com/c/B0H8fh3L/886-feature-flag-the-editable-unlock-tool

@JR-G JR-G requested review from MylesJarvis and a team November 14, 2023 10:54
Copy link
Contributor

@zarembas zarembas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording is a bit confusing around those context specs, unlocked for editing might mean that support has enabled editing on the application and not enabled the feature flag.

@JR-G JR-G force-pushed the feature-flag-the-editable-unlock-tool branch from bd8a95f to 72117e3 Compare November 14, 2023 11:19
@JR-G JR-G merged commit 79182e0 into main Nov 14, 2023
23 checks passed
@JR-G JR-G deleted the feature-flag-the-editable-unlock-tool branch November 14, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants