Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexes to fields commonly used in queries to build emails #9551

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

Context

When I looked at the email queries earlier, it was clear could potentially send nudges to candidates who couldn't do anything with them (users whose accounts were blocked or locked for some reason). So we added those filters.

This PR just adds indexes to those fields to help speed up queries.

Changes proposed in this pull request

This PR just adds indexes to those fields to help speed up queries.

Guidance to review

Link to Trello card

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@elceebee elceebee marked this pull request as draft July 11, 2024 15:23
@carlosmartinez
Copy link
Collaborator

any reason not to merge this?

@carlosmartinez
Copy link
Collaborator

any reason not to merge this?

@elceebee thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants