-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment to production #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated send_to notifications. Ignore object_id change to kv access policy. Ignore changes to tags which are set by policy.
RobertGHippo
had a problem deploying
to
production
July 25, 2024 10:55 — with
GitHub Actions
Failure
sam-c-dfe
requested changes
Jul 25, 2024
RobertGHippo
had a problem deploying
to
production
July 25, 2024 11:47 — with
GitHub Actions
Failure
sam-c-dfe
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deploy IaC/Terraform to production.
Ticket number
EYQB-345
Changes
deploy to production
(copy ofdeploy to staging
)as_service_principal_object_id
variable (principal identity can be read directly from the web app)send_to_subscription_administrator
andsend_to_subscription_co_administrator
notificationsHow Has This Been Tested?
Deployed both dev and staging from pipeline; a couple of outstanding tasks before it can be deployed fully to production (DNS records, certificate generation), but no need to wait for those.
Checklist: