Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment to production #255

Merged
merged 25 commits into from
Jul 25, 2024
Merged

Deployment to production #255

merged 25 commits into from
Jul 25, 2024

Conversation

RobertGHippo
Copy link
Collaborator

@RobertGHippo RobertGHippo commented Jul 22, 2024

Description

Deploy IaC/Terraform to production.

Ticket number

EYQB-345

Changes

  • New job in pipeline, deploy to production (copy of deploy to staging)
  • Removed as_service_principal_object_id variable (principal identity can be read directly from the web app)
  • Ignore changes to tags set automatically by policy: "Environment", "Product", "Service Offering"
  • A couple of instances of ignoring changes to tenant_id (it's very unlikely that it'll change between two automated deployments)
  • Removed some key vault access policies that were duplicates that got in each other's way
  • Removed deprecated send_to_subscription_administrator and send_to_subscription_co_administrator notifications

How Has This Been Tested?

Deployed both dev and staging from pipeline; a couple of outstanding tasks before it can be deployed fully to production (DNS records, certificate generation), but no need to wait for those.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

.github/workflows/main-build-and-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/main-build-and-deploy.yml Outdated Show resolved Hide resolved
Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Web 95% 89%
Dfe.EarlyYearsQualification.Content 91% 91%
Dfe.EarlyYearsQualification.Mock 100% 95%
Summary 95% (2462 / 2598) 90% (349 / 386)

Minimum allowed line rate is 90%

@RobertGHippo RobertGHippo merged commit a169fcb into main Jul 25, 2024
5 of 6 checks passed
@RobertGHippo RobertGHippo deleted the feature/prod-deployment branch July 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants