Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EYQB-491: initial commit of the divider and hint text logic #298

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

sam-c-dfe
Copy link
Collaborator

Description

Commit of the divider and hint text logic

Ticket number (if applicable) - EYQB-491

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Screenshots

image

image

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam-c-dfe sam-c-dfe requested review from DanielClarkeEducation and RobertGHippo and removed request for DanielClarkeEducation August 8, 2024 08:27
@sam-c-dfe sam-c-dfe marked this pull request as ready for review August 8, 2024 08:39
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Content 91% 89%
Dfe.EarlyYearsQualification.Web 96% 90%
Dfe.EarlyYearsQualification.Mock 100% 100%
Summary 95% (2784 / 2927) 91% (433 / 478)

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe merged commit 74c65af into main Aug 8, 2024
4 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/eyqb-491-divider-and-hint-text branch August 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants