Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of the new ratios text field #497

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Initial commit of the new ratios text field #497

merged 3 commits into from
Jan 9, 2025
+182 −52

Conversation

sam-c-dfe
Copy link
Collaborator

Description

Initial commit of the new ratios text field

Ticket number (if applicable) - EYQB-765

How Has This Been Tested?

Running locally, unit tests and E2E test

Screenshots

Please include screenshots if applicable.

Checklist:

  • My code follows the standards used within this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests (Unit, E2E) that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sam-c-dfe sam-c-dfe marked this pull request as ready for review January 8, 2025 11:38
RobertGHippo
RobertGHippo previously approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@RobertGHippo RobertGHippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments 🙂

src/Dfe.EarlyYearsQualification.Content/Entities/DetailsPage.cs Show resolved Hide resolved
tests/Dfe.EarlyYearsQualification.UnitTests/Services/QualificationDetailsServiceTests.cs Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Code Coverage

Package Line Rate Branch Rate Health
Dfe.EarlyYearsQualification.Mock 100% 98% ✔
Dfe.EarlyYearsQualification.Content 98% 90% ✔
Dfe.EarlyYearsQualification.Web 98% 93% ✔
Summary 98% (4195 / 4272) 93% (706 / 762) ✔

Minimum allowed line rate is 90%

@sam-c-dfe sam-c-dfe requested a review from RobertGHippo January 9, 2025 08:36
@sam-c-dfe sam-c-dfe merged commit d8f7905 into release/02-Dec-24-R1 Jan 9, 2025
4 checks passed
@sam-c-dfe sam-c-dfe deleted the feature/eyqb-765-new-ratios-text branch January 9, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGHippo RobertGHippo RobertGHippo approved these changes

@ThomasWhittington ThomasWhittington Awaiting requested review from ThomasWhittington

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sam-c-dfe @RobertGHippo