Add column count validation #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeng
force-pushed
the
add-column-count-validation
branch
from
dea6ced to
5189880
Compare
malcolmbaig
reviewed
Jan 24, 2024
spec/system/support_interface/support_user_uploads_a_csv_file_spec.rb
Outdated
Show resolved
Hide resolved
malcolmbaig
approved these changes
Jan 24, 2024
When creating a ChildrensBarredListEntry from a CSV row we want to validate that the row has the correct number of columns to avoid the data being incorrectly populated, particularly when Excel unhelpfully removes the first column if it has no values i.e. none of the rows have TRNs which is common. Add a source_column_count parameter that can be passed when we want to validate.L
As we create a ChildrensBarredListEntry from each CSV row we want to check that the row has the correct number of columns to avoid errors where the data is a column out if the CSV has been incorrectly created. Pass the row column count with the params.
gpeng
force-pushed
the
add-column-count-validation
branch
from
5189880 to
b4881f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Excel annoyingly drops the first column from a CSV export if the column has no entries. Testers have fallen foul of this and created records with the data in incorrect columns and validation messages are then a bit unhelpful.
Changes proposed in this pull request
Validate the column count in each row to enable us to provide a more helpful error message when this happens.
Checklist