Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Azure RBAC changes #232

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Enable Azure RBAC changes #232

merged 2 commits into from
Jan 31, 2024

Conversation

VenkataChalla554
Copy link
Contributor

@VenkataChalla554 VenkataChalla554 commented Jan 30, 2024 •
edited
Loading

Context

https://trello.com/c/3m8PNLG6/937-enable-azure-rbac-deployment-on-all-services

Changes proposed in this pull request

Enable Azure RBAC Changes
1 ) Replaced set-arm-environment-variables to set-kubelogin-environment
2 ) kubelogin convert-kubeconfig -l $(if ${GITHUB_ACTIONS},spn,azurecli) Added to get-cluster-credentials
3 ) kubernetes provider updated to get RBAC enabled.
4 ) Chnages done github action to use make get-cluster-credentials

Guidance to review

Link to Trello card

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@VenkataChalla554 VenkataChalla554 added the deploy Deploys a review app label Jan 30, 2024
@github-actions github-actions bot temporarily deployed to review-232 January 30, 2024 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to review-232 January 30, 2024 16:13 Destroyed
saliceti
saliceti reviewed Jan 30, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@saliceti
Copy link
Member

Please update the doc with the make command:

check-childrens-barred-list/docs/aks-cheatsheet.md

Line 65 in d87aa14

az aks get-credentials -g s189t01-tsc-ts-rg -n s189t01-tsc-test-aks

@github-actions github-actions bot temporarily deployed to review-232 January 31, 2024 10:29 Destroyed
@github-actions github-actions bot temporarily deployed to review-232 January 31, 2024 11:06 Destroyed
saliceti
saliceti reviewed Jan 31, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
saliceti
saliceti reviewed Jan 31, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@VenkataChalla554 VenkataChalla554 force-pushed the 937-enable-azure-rbac-deployment-on-all-services branch from fbcd00d to 655021e Compare January 31, 2024 11:49
@github-actions github-actions bot temporarily deployed to review-232 January 31, 2024 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to review-232 January 31, 2024 12:28 Destroyed
saliceti
saliceti reviewed Jan 31, 2024
View reviewed changes
docs/aks-cheatsheet.md Outdated Show resolved Hide resolved
saliceti
saliceti reviewed Jan 31, 2024
View reviewed changes
docs/aks-cheatsheet.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to review-232 January 31, 2024 13:24 Destroyed
@VenkataChalla554 VenkataChalla554 merged commit d1a52f0 into main Jan 31, 2024
11 checks passed
@VenkataChalla554 VenkataChalla554 deleted the 937-enable-azure-rbac-deployment-on-all-services branch January 31, 2024 15:09
@steventux steventux mentioned this pull request Feb 8, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saliceti saliceti saliceti approved these changes

Assignees
No one assigned
Labels
deploy Deploys a review app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VenkataChalla554 @saliceti