feat: Enable health checks and add health check around the configuration #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgparkins
reviewed
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opinions on the static nature of the health checks welcome. We could scan the whole app config object and check all strings are populated but (i) some string are not used in prod - they could be in an ignore list & (ii) it could lead to unexpected prod deployment failure if new config was introduced and not configured correctly in the health check.
Have left as a static check for the moment but again new config needs to be manually added to it, which can also be overlooked. Opinions welcome.