Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform release #464

Closed
wants to merge 14 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/docker-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ jobs:
# transparency data even for private images, pass --force to cosign below.
# https://github.com/sigstore/cosign
- name: Install Cosign
uses: sigstore/cosign-installer@main
with:
cosign-release: 'v1.13.1'
uses: sigstore/[email protected]
- name: Check install!
run: cosign version
- name: Sign the published Docker image
Expand All @@ -110,4 +108,4 @@ jobs:
COSIGN_EXPERIMENTAL: "true"
# This step uses the identity token to provision an ephemeral certificate
# against the sigstore community Fulcio instance.
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign {}@${{ steps.build-and-push.outputs.digest }}
run: echo "${{ steps.meta.outputs.tags }}" | xargs -I {} cosign sign --yes {}@${{ steps.build-and-push.outputs.digest }}
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -409,4 +409,7 @@ terraform.rc
# Built Visual Studio Code Extensions
*.vsix

.sonarqube/
.sonarqube/

# Mac Finder attributes files
.DS_Store
3 changes: 2 additions & 1 deletion Childrens-Social-Care-CPD/Properties/launchSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
"Childrens_Social_Care_CPD": {
"commandName": "Project",
"launchBrowser": true,
"applicationUrl": "https://localhost:7112;http://localhost:5112",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development"
},
"applicationUrl": "https://localhost:7112;http://localhost:5112",
"dotnetRunMessages": true
},
"IIS Express": {
Expand All @@ -28,6 +28,7 @@
"commandName": "Docker",
"launchBrowser": true,
"launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}",
"environmentVariables": {},
"publishAllPorts": true,
"useSSL": true
}
Expand Down
11 changes: 6 additions & 5 deletions Childrens-Social-Care-CPD/Views/Shared/_SiteLayout.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@await RenderSectionAsync("Head", required: false)
@Html.RenderScripts(ScriptPosition.HeadEnd)

<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="~/assets/images/favicon.ico" type="image/x-icon">
<link rel="shortcut icon" href="~/assets/images/favicon.ico" type="image/x-icon">

</head>
<body class="govuk-template__body">
Expand All @@ -32,13 +32,14 @@
<partial name="_Footer" />
<script src="~/lib/jquery/dist/jquery.min.js"></script>
<script>
document.body.className = ((document.body.className) ? document.body.className + ' js-enabled' : 'js-enabled');
document.body.className += ' js-enabled' + ('noModule' in HTMLScriptElement.prototype ? ' govuk-frontend-supported' : '');
</script>
<!-- component HTML -->
<script src="/javascript/govuk-frontend-4.7.0.min.js"></script>
<script src="/javascript/govuk-frontend.min.js" type="module"></script>
<script src="/javascript/dfefrontend-1.0.1.min.js"></script>
<script>
window.GOVUKFrontend.initAll()
<script type="module">
import { initAll } from '/javascript/govuk-frontend.min.js'
initAll()
</script>
@await RenderSectionAsync("Scripts", required: false)
@Html.RenderScripts(ScriptPosition.BodyEnd)
Expand Down
2 changes: 2 additions & 0 deletions Childrens-Social-Care-CPD/compile-sass.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
npx sass --style=expanded --charset --source-map-urls=relative ./styles/scss/application.scss ./wwwroot/css/application.css
npx sass --style=compressed --charset --source-map-urls=relative ./styles/scss/application.scss ./wwwroot/css/application.min.css
24 changes: 20 additions & 4 deletions Childrens-Social-Care-CPD/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Childrens-Social-Care-CPD/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@ministryofjustice/frontend": "^1.8.0",
"dfe-frontend-alpha": "^1.0.1",
"govuk-frontend": "^4.7.0",
"govuk-frontend": "^5.2.0",
"jquery": "^3.7.0"
}
}
2 changes: 1 addition & 1 deletion Childrens-Social-Care-CPD/styles/scss/application.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ $govuk-global-styles: true;
$govuk-new-link-styles: true;
$moj-images-path: "/assets/images/moj/";

@import "../../node_modules/govuk-frontend/govuk/all";
@import "../../node_modules/govuk-frontend/dist/govuk/all";
@import "../../node_modules/@ministryofjustice/frontend/moj/components/filter/filter";
@import '../../node_modules/dfe-frontend-alpha/packages/dfefrontend';
@import "overrides/dfe-overrides";
Expand Down
Binary file modified Childrens-Social-Care-CPD/wwwroot/assets/images/favicon.ico
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading