Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aj march update #177

Merged
merged 41 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
a783445
Updates for March update
Feb 19, 2024
05ed774
our work integration with the DH service
Feb 19, 2024
eaa30e3
new link
Feb 19, 2024
e507c81
Correcting GOV.UK Design System
Feb 19, 2024
64d944c
typos
Feb 19, 2024
c09cb66
typo
Feb 19, 2024
5b9eb76
typos
Feb 19, 2024
17b5119
reduced recent DH posts from 6 to 4
Feb 19, 2024
26efe48
our work
Feb 20, 2024
d9f1d41
Last release
Feb 20, 2024
1fc7464
Set theme color
Feb 22, 2024
88094c7
Removal of guidance for DH posts fixes #175
Feb 23, 2024
886579e
fixing link to examples
Feb 24, 2024
a1b8404
Fixing heading style for other design systems
Feb 24, 2024
7fca332
Updated design goals
Feb 24, 2024
f199e3b
Added link to figma library
Feb 24, 2024
f601a17
change
Feb 25, 2024
d312342
tools form
Feb 25, 2024
e35b348
Fixes #176
Feb 28, 2024
25cb15b
View removal
Feb 28, 2024
e99db7b
View
Feb 28, 2024
7edb093
Improved tools page
Feb 28, 2024
9fc8ba3
services fix
Feb 28, 2024
87e0f85
adding the new feedback feature to try it out
Feb 29, 2024
24578ea
updated feedback
Mar 1, 2024
1004ce1
Services js
Mar 1, 2024
b120081
style
Mar 1, 2024
b59805c
a11y fixes
Mar 1, 2024
dd06757
More a11y fixes
Mar 1, 2024
5ee2a6a
a11y fixes
Mar 1, 2024
cc25ff7
fix
Mar 1, 2024
a03f74d
fixes
Mar 4, 2024
8ecb641
Update service-assessment-service.html
kerryalyons Mar 5, 2024
6bf5c61
our work
Mar 5, 2024
c6cc1ac
feedback
Mar 6, 2024
1248025
design-ops to designops
Mar 7, 2024
e4daf0e
satisfaction scores feature
Mar 7, 2024
e9d8713
fixing link
Mar 7, 2024
bf1824a
guidance on goals
Mar 7, 2024
c138f82
Updated sitemaps
Mar 7, 2024
9f8a7ea
Merge branch 'main' of https://github.com/DFE-Digital/design into aj-…
Mar 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .DS_Store
Binary file not shown.
8 changes: 8 additions & 0 deletions .trunk/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
*out
*logs
*actions
*notifications
*tools
plugins
user_trunk.yaml
user.yaml
10 changes: 10 additions & 0 deletions .trunk/configs/.markdownlint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Autoformatter friendly markdownlint config (all formatting rules disabled)
default: true
blank_lines: false
bullet: false
html: false
indentation: false
line_length: false
spaces: false
url: false
whitespace: false
10 changes: 10 additions & 0 deletions .trunk/configs/.yamllint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
rules:
quoted-strings:
required: only-when-needed
extra-allowed: ['{|}']
empty-values:
forbid-in-block-mappings: true
forbid-in-flow-mappings: true
key-duplicates: {}
octal-values:
forbid-implicit-octal: true
37 changes: 37 additions & 0 deletions .trunk/trunk.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This file controls the behavior of Trunk: https://docs.trunk.io/cli
# To learn more about the format of this file, see https://docs.trunk.io/reference/trunk-yaml
version: 0.1
cli:
version: 1.18.1
# Trunk provides extensibility via plugins. (https://docs.trunk.io/plugins)
plugins:
sources:
- id: trunk
ref: v1.4.1
uri: https://github.com/trunk-io/plugins
# Many linters and tools depend on runtimes - configure them here. (https://docs.trunk.io/runtimes)
runtimes:
enabled:
- [email protected]
- [email protected]
# This is the section where you manage your linters. (https://docs.trunk.io/check/configuration)
lint:
enabled:
- [email protected]
- [email protected]
- [email protected]
- git-diff-check
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
actions:
disabled:
- trunk-announce
- trunk-check-pre-push
- trunk-fmt-pre-commit
enabled:
- trunk-upgrade-available
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ notifyKey=preprod-x
BASE_URL=http://localhost:3066
sessionkey=x
```
Contact Design Ops for the keys to use in your local environment. These must never be checked in to source code - the file is included in the .GITIGNORE file.
Contact DesignOps for the keys to use in your local environment. These must never be checked in to source code - the file is included in the .GITIGNORE file.

Run `npm install`

Expand Down
Binary file modified app/.DS_Store
Binary file not shown.
Binary file modified app/assets/.DS_Store
Binary file not shown.
Binary file added app/assets/images/app.jpeg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/app.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/cover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/ehcp.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified app/assets/images/familyhubs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/frontends.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/layers.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/part-of-gdd.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/sas_manage.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added app/assets/images/temp.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion app/assets/js/all.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

55 changes: 16 additions & 39 deletions app/assets/js/feedback.js
Original file line number Diff line number Diff line change
@@ -1,51 +1,28 @@
var feedbackTab = document.getElementById('feedback-tab');
var feedbackPanel = document.getElementById('feedback-panel');

var feedbackForm = document.getElementById('feedback-form');
var feedbackFormInput = document.getElementById('feedback_form_input');
var servicesTab = document.getElementById('services-tab');
var servicesPanel = document.getElementById('services-panel');

var submitButton = document.getElementById('submitbutton');
var cancelButton = document.getElementById('cancelbutton');
var closeNav = document.getElementById('closeNav');

feedbackTab.addEventListener('click', function (event) {

servicesTab.addEventListener('click', function (event) {
event.preventDefault(); // prevent the default link behavior
if (feedbackPanel.style.display === 'none') {
feedbackPanel.style.display = 'block';
feedbackPanel.setAttribute('aria-hidden', 'false');
feedbackTab.setAttribute('aria-expanded', 'true');
if (servicesPanel.style.display === 'none') {
servicesPanel.style.display = 'block';
servicesPanel.setAttribute('aria-hidden', 'false');
servicesTab.setAttribute('aria-expanded', 'true');
} else {
feedbackPanel.style.display = 'none';
feedbackPanel.setAttribute('aria-hidden', 'true');
feedbackTab.setAttribute('aria-expanded', 'false');
servicesPanel.style.display = 'none';
servicesPanel.setAttribute('aria-hidden', 'true');
servicesTab.setAttribute('aria-expanded', 'false');
}
});


submitButton.addEventListener('click', function (event) {
closeNav.addEventListener('click', function (event) {
event.preventDefault();
var formData = new FormData(feedbackForm);
var xhr = new XMLHttpRequest();

xhr.open('POST', '/submit-feedback');
xhr.onload = function () {
if (xhr.status === 200) {
feedbackFormInput.value = "";
feedbackTab.textContent = 'Feedback submitted';
feedbackPanel.style.display = 'none';
feedbackPanel.setAttribute('aria-hidden', 'true');
feedbackTab.setAttribute('aria-expanded', 'false');
}
};
xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');
xhr.send(new URLSearchParams(formData).toString());

});

cancelButton.addEventListener('click', function (event) {
event.preventDefault();

feedbackFormInput.value = "";
feedbackPanel.style.display = 'none';
feedbackPanel.setAttribute('aria-hidden', 'true');
feedbackTab.setAttribute('aria-expanded', 'false');
servicesPanel.style.display = 'none';
servicesPanel.setAttribute('aria-hidden', 'true');
servicesTab.setAttribute('aria-expanded', 'false');
});
1 change: 1 addition & 0 deletions app/assets/js/govuk-frontend.min.js

Large diffs are not rendered by default.

Loading
Loading