-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Project Notes, Establishment Search, and Risk Rating patterns to the RSD design system section #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the project notes content, but not the example and HTML. Updated formatting of user needs sections to be consistent.
Added some images for notes.
Images added.
Added project and task headings for adding notes.
Updated text for project notes, with placeholder text for screenshots.
Updates to text and images in project notes.
Edited the text, and the task note image.
Updated the example and HTML for task notes content.
Removed screenshots which duplicate the code snippets.
Updated the 'How it works' intro paragraph to make the pattern easier to read.
Changed 'Note' to 'Add a note' in error message snippet. Removed bullet point about notes being visible to everyone, as this is implied.
Added 'CSS' to classes content. Reviewed and updated the rest of the content.
Fixed the page structure, following meeting with Ming.
Tweaked wording.
Combined the 'When to use this pattern' and 'How it works' sections, to make the context clearer. Updated the wordings about which page to take users back to when searching.
Added a reference numbers section, based on the 'Search for a trust' wiki design pattern: https://dfe-gov-uk.visualstudio.com/Academies-and-Free-Schools-SIP/_wiki/wikis/Academies-and-Free-Schools-SIP.wiki/5190/Search-for-a-trust
Updated search for an establishment examples.
Updated the trust names.
…tal/design into rsd-ucd-week-2-patterns
Made trust names more realistic.
Added error message guidance.
…tal/design into rsd-ucd-week-2-patterns
Tweaked 2 variations content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Added the following patterns to RSD design system section:
Updated:
Screenshots of UI changes
Before the update
After the update