Skip to content

Commit

Permalink
Users are not directed to update KIM in 'Receive grant payment certif…
Browse files Browse the repository at this point in the history
…icate' task

We are gradually removing any need for or mention of KIM in our applications,
so remove this action in the Receive Grant Payment Certificate task as we do
not want to encourage people to still use KIM.
  • Loading branch information
Laura Porter committed Nov 16, 2023
1 parent c013ac2 commit fcf9e11
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 21 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- transfer projects now collect if the outgoing trust is expected to close once
the transfer is completed and this is shown on the about the project tab

### Changed

- Users are not directed to update KIM for the 'Receive grant payment
certificate' task

## [Release-46][release-46]

### Added
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
class Conversion::Task::ReceiveGrantPaymentCertificateTaskForm < BaseTaskForm
attribute :check_and_save, :boolean
attribute :update_kim, :boolean
end
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

<div class="govuk-form-group">
<%= render(TaskList::CheckBoxActionComponent.new(task: @task, attribute: :check_and_save)) %>
<%= render(TaskList::CheckBoxActionComponent.new(task: @task, attribute: :update_kim)) %>
</div>

<%= form.govuk_submit t("task_list.continue_button.text") if policy(@tasks_data).update? %>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,3 @@ en:
guidance:
html:
<p>You should ask the school to send the certificate. You must record the date each time you contact them in <a href="https://educationgovuk.sharepoint.com/:x:/r/sites/ServiceDeliveryDirectorate/_layouts/15/Doc.aspx?sourcedoc=%7BDC55D68D-3415-4923-A502-44B49DB05C0E%7D&amp;file=Support%20Grant%20Certificate%20Assurance%20Report%20-%20RCS.xlsx&amp;action=default&amp;mobileredirect=true" target="_blank">the support grant assurance report (opens in new tab)</a>.</p>

update_kim:
title: Update KIM with date certificate is received
hint:
html: <p>Find this information in the ESFA handover section in KIM.</p>
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class RemoveUpdateKimActionFromReceiveGrantPaymentTask < ActiveRecord::Migration[7.0]
def change
remove_column :conversion_tasks_data, :receive_grant_payment_certificate_update_kim, :boolean
end
end
3 changes: 1 addition & 2 deletions db/schema.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions spec/accessibility/projects_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@
end

scenario "project completed page" do
tasks_data = create(:conversion_tasks_data,
receive_grant_payment_certificate_check_and_save: true,
receive_grant_payment_certificate_update_kim: true)
tasks_data = create(:conversion_tasks_data, receive_grant_payment_certificate_check_and_save: true)
project = create(:conversion_project,
regional_delivery_officer: user,
assigned_to: user,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@

context "when all conditions have been met and the academy has opened" do
let(:tasks_data) {
create(:conversion_tasks_data,
receive_grant_payment_certificate_check_and_save: true,
receive_grant_payment_certificate_update_kim: true)
create(:conversion_tasks_data, receive_grant_payment_certificate_check_and_save: true)
}
let(:project) {
create(:conversion_project,
Expand Down
8 changes: 2 additions & 6 deletions spec/models/conversion/project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,7 @@

context "when the ReceiveGrantPaymentCertificateTaskForm is NOT completed" do
let(:tasks_data) {
create(:conversion_tasks_data,
receive_grant_payment_certificate_check_and_save: nil,
receive_grant_payment_certificate_update_kim: nil)
create(:conversion_tasks_data, receive_grant_payment_certificate_check_and_save: nil)
}

it "returns false" do
Expand All @@ -120,9 +118,7 @@

context "when the ReceiveGrantPaymentCertificateTaskForm is completed" do
let(:tasks_data) {
create(:conversion_tasks_data,
receive_grant_payment_certificate_check_and_save: true,
receive_grant_payment_certificate_update_kim: true)
create(:conversion_tasks_data, receive_grant_payment_certificate_check_and_save: true)
}

it "returns true" do
Expand Down

0 comments on commit fcf9e11

Please sign in to comment.