Merge pull request #1287 from DFE-Digital/fix/152458-sponsored-suppor…

…t-grant-task-is-not-completable

(Fix) The Sponsored support grant task is not completable

CHANGELOG.md

@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Fix Conversion project incoming sharepoint link edit view to not display
   outgoing trust sharepoint link field.
 - Fix statistics page to show accurate data for Transfer's `by region` table.
+- The Sponsored support grant task in Conversions was not completable - fixed
 
 ### Added
 

app/forms/conversion/task/sponsored_support_grant_task_form.rb

@@ -1,5 +1,4 @@
 class Conversion::Task::SponsoredSupportGrantTaskForm < BaseOptionalTaskForm
-  attribute :eligibility, :boolean
   attribute :payment_amount, :boolean
   attribute :payment_form, :boolean
   attribute :send_information, :boolean

db/migrate/20240110145231_remove_eligibility_from_sponsored_support_grant_task.rb

@@ -0,0 +1,5 @@
+class RemoveEligibilityFromSponsoredSupportGrantTask < ActiveRecord::Migration[7.0]
+  def change
+    remove_column :conversion_tasks_data, :sponsored_support_grant_eligibility, :boolean
+  end
+end

spec/features/conversions/users_can_complete_conversion_tasks_spec.rb

@@ -233,6 +233,25 @@
 
       expect(project.reload.tasks_data.sponsored_support_grant_type).to eq "full_sponsored"
     end
+
+    scenario "the task can be completed" do
+      choose "Full sponsored"
+      page.find_all(".govuk-checkboxes__input").each { |checkbox| checkbox.click }
+      # uncheck the Not applicable box
+      page.find(".govuk-checkboxes__label", text: "Not applicable").click
+      click_on I18n.t("task_list.continue_button.text")
+
+      table_row = page.find("li.app-task-list__item", text: I18n.t("conversion.task.sponsored_support_grant.title"))
+      expect(table_row).to have_content("Completed")
+    end
+
+    scenario "the task can be marked as Not applicable" do
+      page.find(".govuk-checkboxes__label", text: "Not applicable").click
+      click_on I18n.t("task_list.continue_button.text")
+
+      table_row = page.find("li.app-task-list__item", text: I18n.t("conversion.task.sponsored_support_grant.title"))
+      expect(table_row).to have_content("Not applicable")
+    end
   end
 
   describe "the confirm all conditions met task" do