Ensure CI workflow fails when psql restore encounters an error #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if `psql` encounters an error when restoring the database it will continue with the rest of the restore operation. Instead, we want it to stop and return an exit code that will trigger the workflow to fail. We can do this by passing the `ON_ERROR_STOP` flag.
|
Review app deployed to https://cpd-ecf-review-5465-web.test.teacherservices.cloud |
cwrw
approved these changes
Jan 22, 2025
leandroalemao
temporarily deployed
to
production
GitHub Actions
Inactive
leandroalemao
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Hi @ethax-ross Ran the action and saw no errors.. so after merging this.. let's keep an eye out to ensure its behaving as expected.. as you said. tks
mooktakim
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-3954
Context
We have an issue with our snapsort restore workflow whereby if the psql operation errors it will continue and the workflow will succeed, even though it was not successful.
We want to fail the workflow if the restore has errors.
Changes proposed in this pull request
We can do this by passing the
ON_ERROR_STOPflag.Guidance to review
I ran the restore a couple of times off this branch and it was successful, I haven't been able to trigger an error - its something I think we'll just need to keep an eye out for after its merged to ensure its behaving as expected.