Skip to content

Commit

Permalink
Update webhook env var in SlackClient
Browse files Browse the repository at this point in the history
This env var hasn't been set for the production app since the AKS
migration, and is needed by SlackClient for reporting performance alerts
and Zendesk health to Slack.

Secrets for this service are now split into infra and app lists. The
infra list contains a Slack webhook URL that is used when database
backups fail. We need that same URL in the app list.

In addition to adding SLACK_WEBHOOK to the app secrets via the Azure
Portal, this PR simply aligns the name of the env var between the two
places in the codebase it is currently used.
  • Loading branch information
malcolmbaig committed Feb 21, 2024
1 parent 20ee431 commit 1a7e8af
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/services/slack_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def create_message(message)
private

def client
Faraday.new(url: ENV.fetch("SLACK_WEBHOOK_URL")) do |faraday|
Faraday.new(url: ENV.fetch("SLACK_WEBHOOK")) do |faraday|
faraday.request :json
faraday.response :json
faraday.response :logger, nil, { bodies: true, headers: true }
Expand Down

0 comments on commit 1a7e8af

Please sign in to comment.