-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix review app #1011
Merged
Merged
Fix review app #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKS review app deployed to https://find-a-lost-trn-review-pr-1011.test.teacherservices.cloud |
johnake
force-pushed
the
946-faltrn-fix-review-app
branch
from
February 1, 2024 13:24
7f96b18
to
12ed521
Compare
johnake
force-pushed
the
946-faltrn-fix-review-app
branch
from
February 1, 2024 15:53
25358c6
to
dea9241
Compare
johnake
force-pushed
the
946-faltrn-fix-review-app
branch
from
February 1, 2024 15:57
dea9241
to
57d56b1
Compare
johnake
force-pushed
the
946-faltrn-fix-review-app
branch
from
February 2, 2024 09:07
a89c855
to
f52573f
Compare
saliceti
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The review app URL doesn't not show here:
#1005 (comment)
Also the delete review job failed
Changes proposed in this pull request
Fix the review app url issue
Fix the Delete review app workflow
Guidance to review
Ensure the review url shows just below here
Ensure the delete review app runs ok after PR is closed and merge
Checklist