Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix review app #1011

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix review app #1011

merged 1 commit into from
Feb 2, 2024

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Feb 1, 2024

Context

The review app URL doesn't not show here:

#1005 (comment)

Also the delete review job failed

Changes proposed in this pull request

  • Fix the review app url issue

  • Fix the Delete review app workflow

Guidance to review

  • Ensure the review url shows just below here

  • Ensure the delete review app runs ok after PR is closed and merge

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@johnake johnake requested a review from a team as a code owner February 1, 2024 12:59
@johnake johnake added the deploy label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

@johnake johnake removed the deploy label Feb 1, 2024
@johnake johnake force-pushed the 946-faltrn-fix-review-app branch from 7f96b18 to 12ed521 Compare February 1, 2024 13:24
@johnake johnake added the deploy label Feb 1, 2024
@johnake johnake changed the title WIP: Fix review app Fix review app Feb 1, 2024
@johnake
Copy link
Contributor Author

johnake commented Feb 1, 2024

Faltrn: Fix review app

@johnake johnake force-pushed the 946-faltrn-fix-review-app branch from 25358c6 to dea9241 Compare February 1, 2024 15:53
@johnake johnake force-pushed the 946-faltrn-fix-review-app branch from dea9241 to 57d56b1 Compare February 1, 2024 15:57
@johnake johnake closed this Feb 1, 2024
@johnake johnake reopened this Feb 1, 2024
@johnake johnake changed the title Fix review app WIP: Fix review app Feb 1, 2024
@johnake johnake closed this Feb 1, 2024
@johnake johnake reopened this Feb 1, 2024
@johnake johnake closed this Feb 1, 2024
@johnake johnake reopened this Feb 1, 2024
@johnake johnake reopened this Feb 2, 2024
@johnake johnake closed this Feb 2, 2024
@johnake johnake reopened this Feb 2, 2024
@johnake johnake closed this Feb 2, 2024
@johnake johnake reopened this Feb 2, 2024
@johnake johnake closed this Feb 2, 2024
@johnake johnake reopened this Feb 2, 2024
@johnake johnake closed this Feb 2, 2024
@johnake johnake reopened this Feb 2, 2024
@johnake johnake force-pushed the 946-faltrn-fix-review-app branch from a89c855 to f52573f Compare February 2, 2024 09:07
@johnake johnake changed the title WIP: Fix review app Fix review app Feb 2, 2024
@johnake johnake merged commit 20ee431 into main Feb 2, 2024
11 checks passed
@johnake johnake deleted the 946-faltrn-fix-review-app branch February 2, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants