Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sidekiq < 7 #1017

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Pin sidekiq < 7 #1017

merged 1 commit into from
Feb 8, 2024

Conversation

gpeng
Copy link
Contributor

@gpeng gpeng commented Feb 2, 2024

Context

We use Sidekiq. It uses Redis. Sidekiq 7 requires Redis >= 6.2 which Azure doesn't currently support. Dependabot keeps opening an upgrade PR and when we merge it the worker instances can't start.

Changes proposed in this pull request

Pin the Sidekiq version to < 7

Checklist

  • Rebased main
  • Cleaned commit history
  • Tested by running locally

v7 requires Redis 6.2 which Azure doesn't currently support.
@gpeng gpeng requested a review from a team as a code owner February 2, 2024 14:46
@malcolmbaig malcolmbaig merged commit 7bb76fb into main Feb 8, 2024
11 checks passed
@malcolmbaig malcolmbaig deleted the pin-sidekiq-version branch February 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants