-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature In Progress - Add no access page #580
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also test BasePageModel and ContentPageModel in their own dedicated test files and only test changes to default behaviour in subclasses
This is to enable a redirect to a friendly page for users that are authenticated with DfE AD but do not have access to FIAT
…ecommendation of `Lax` It can't be `Strict` because auth is done externally to the application
This is to enable a log in retry for users who may have stale role claims in their auth cookie. ADR to follow
Reduces code, makes it easier to see which pages have anonymous access and aggregates the behavior into one place
dynamictulip
temporarily deployed
to
development
October 30, 2024 15:53 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
October 30, 2024 15:54 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
October 30, 2024 15:55 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
October 30, 2024 15:57 — with
GitHub Actions
Inactive
dynamictulip
had a problem deploying
to
development
October 30, 2024 15:59 — with
GitHub Actions
Failure
…angelog Update changelog with no-access page changes
dynamictulip
temporarily deployed
to
development
October 31, 2024 10:36 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
October 31, 2024 10:36 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
October 31, 2024 10:38 — with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
dynamictulip
temporarily deployed
to
development
October 31, 2024 10:40 — with
GitHub Actions
Inactive
dynamictulip
had a problem deploying
to
development
October 31, 2024 10:42 — with
GitHub Actions
Failure
Archived branch to pick up in future - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the auth processes in FIAT to allow unauthorised users to be redirected to a "No Access" page.
User Story 135671: Build: Authentication - Add access-denied screen
Changes
No Access specific changes
Other changes:
SameSite
setting for the login cookie to current Microsoft recommendation ofLax
(This was a long running piece of work with change of direction which originally touched these areas)
Screenshots of UI changes
New "No Access" page
Header changes
Authorised user (No change)
Unauthorised user
Footer changes
Authorised user (No change)
Unauthorised user
Checklist