Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ofsted database from MIS tables to MIS_MSTR tables #678

Merged
merged 14 commits into from
Jan 3, 2025
Merged

Change ofsted database from MIS tables to MIS_MSTR tables #678

merged 14 commits into from
Jan 3, 2025

Conversation

nwarms
Copy link
Collaborator

@nwarms nwarms commented Dec 20, 2024 •
edited by CMurrell148
Loading

User Story 193754: Build: Move to Gold Layer Tables for Ofsted Data
Switch to using the new ofsted tables.

Changes

  • Remove the old MIS models
  • Create new models for EstablishmentFiat and FutherEducationEstablishmentFiat tables
  • Create db context for new models and tables
  • Switch academy repository to using the new tables
  • Update AcademyRepositoryOfstedTests to use the new model

Screenshots of UI changes

No UI changes

Checklist

  • Pull request attached to the appropriate user story in Azure DevOps
  • ADR decision log updated (if needed)
  • Release notes added to CHANGELOG.md
  • Testing complete - all manual and automated tests pass

@nwarms nwarms marked this pull request as ready for review December 20, 2024 11:20
@nwarms nwarms force-pushed the change-ofsted-database branch from 46bd1ba to 4622416 Compare December 20, 2024 14:27
@nwarms nwarms force-pushed the change-ofsted-database branch from 4622416 to 6695be4 Compare January 2, 2025 14:34
@nwarms nwarms force-pushed the change-ofsted-database branch from 9a7b96b to 8fe18c5 Compare January 2, 2025 15:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@CMurrell148
Copy link
Contributor

QA Pass - regression checked the ofsted page for any new data issues etc.

@CMurrell148 CMurrell148 merged commit ffb4220 into main Jan 3, 2025
18 checks passed
@CMurrell148 CMurrell148 deleted the change-ofsted-database branch January 3, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dynamictulip dynamictulip dynamictulip approved these changes

@dneed-nimble dneed-nimble Awaiting requested review from dneed-nimble dneed-nimble is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwarms @CMurrell148 @dynamictulip