Merge pull request #1476 from DFE-Digital/dependabot/nuget/Fody-6.8.2 #3603
martyn-wAnnotations
10 warnings
|
sonarcloud:
GetIntoTeachingApi/Attributes/PrivateShortTermResponseCacheAttribute.cs#L5
Specify AttributeUsage on 'PrivateShortTermResponseCacheAttribute' to improve readability, even though it inherits it from its base type. (https://rules.sonarsource.com/csharp/RSPEC-3993)
|
|
sonarcloud:
GetIntoTeachingApi/Jobs/LocationSyncJob.cs#L24
Refactor your code not to use hardcoded absolute paths or URIs. (https://rules.sonarsource.com/csharp/RSPEC-1075)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L29
Remove this unread private field '_env' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L87
Define a constant instead of using this literal 'dfe_starttime' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Services/CrmService.cs#L185
Define a constant instead of using this literal 'contact' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Services/RedisService.cs#L14
Remove the field '_options' and declare it as a local variable in the relevant methods. (https://rules.sonarsource.com/csharp/RSPEC-1450)
|
|
sonarcloud:
GetIntoTeachingApi/Middleware/RequestResponseLoggingMiddleware.cs#L34
Remove the unused private method 'ReadStream'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
|
|
sonarcloud:
GetIntoTeachingApi/Services/Store.cs#L26
Remove this unread private field '_env' or refactor the code to use its value. (https://rules.sonarsource.com/csharp/RSPEC-4487)
|
|
sonarcloud:
GetIntoTeachingApi/Migrations/20200812092655_TeachingEventBuildingOnDeleteNullify.cs#L10
Define a constant instead of using this literal 'FK_TeachingEvents_TeachingEventBuildings_BuildingId' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|
|
sonarcloud:
GetIntoTeachingApi/Migrations/20200812092655_TeachingEventBuildingOnDeleteNullify.cs#L11
Define a constant instead of using this literal 'TeachingEvents' 4 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
|