Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove completed field and add sent to provider at #1295

Closed
wants to merge 7 commits into from
Closed

Remove completed field and add sent to provider at #1295

wants to merge 7 commits into from

Conversation

plisovin
Copy link
Contributor

@plisovin plisovin commented Sep 12, 2023 •
edited
Loading

Trello card

Trello-4999

Context

Removed the deprecated filed completed and add new filed sent_to_provider_at

@plisovin plisovin temporarily deployed to Development September 12, 2023 11:43 — with GitHub Actions Inactive
@github-actions github-actions bot added VisualCSharp Visual C # Test Test scripts and harnesses labels Sep 12, 2023
@plisovin plisovin changed the title Remove completed field and add send to provider at Remove completed field and add sent to provider at Sep 15, 2023
asatwal
asatwal previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Just a few comments on what seems to be test values and making them realistic, if I've understood correctly.

...Output/ApplyCandidateApi/sync_with_a_new_candidate_and_fully_populated_application_form.json Outdated Show resolved Hide resolved
...Output/ApplyCandidateApi/sync_with_a_new_candidate_and_fully_populated_application_form.json Outdated Show resolved Hide resolved
.../ApplyCandidateApi/sync_with_an_existing_candidate_and_fully_populated_application_form.json Outdated Show resolved Hide resolved
asatwal
asatwal approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@asatwal asatwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@plisovin plisovin force-pushed the remove-deprecated-field-and-add-new branch from a765e60 to d3f5138 Compare September 19, 2023 12:08
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ekumachidi ekumachidi self-assigned this Jan 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@martyn-w
Copy link
Contributor

martyn-w commented Aug 9, 2024

Closing as this has been open since 2023

@martyn-w martyn-w closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asatwal asatwal asatwal approved these changes

@StackedPancakez StackedPancakez Awaiting requested review from StackedPancakez

Assignees

@ekumachidi ekumachidi

Labels
Test Test scripts and harnesses VisualCSharp Visual C #
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plisovin @martyn-w @asatwal @ekumachidi