Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RBAC to project #1355

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Added RBAC to project #1355

merged 1 commit into from
Jan 30, 2024

Conversation

temitope777
Copy link
Contributor

@temitope777 temitope777 commented Jan 30, 2024

Trello card
https://trello.com/c/3m8PNLG6/937-enable-azure-rbac-deployment-on-all-services

Context
Enable azure rbac on deployment (for when it is enabled in the cluster)

Changes proposed in this pull request
Update Makefile, terraform and workflows to use rbac if configured for the cluster

Guidance to review
make env terraform-plan

@github-actions github-actions bot added the DevOps DevOps label Jan 30, 2024
johnake
johnake previously approved these changes Jan 30, 2024
WHY: RBAC is a requisite feature to enhance security
HOW: By make the authentication and authorisation go through the new RBAC feature in MAKEFILE
@temitope777 temitope777 force-pushed the feature/enable-azure-rbac branch from 784a818 to 63dd759 Compare January 30, 2024 12:43
@temitope777 temitope777 requested a review from saliceti January 30, 2024 12:44
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@saliceti saliceti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with make env terraform-plan

@temitope777 temitope777 merged commit aad8fde into master Jan 30, 2024
9 of 10 checks passed
@temitope777 temitope777 deleted the feature/enable-azure-rbac branch January 30, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants