Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Serilog from 3.1.1 to 4.0.0 #1431

Merged
merged 1 commit into from
Jun 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GetIntoTeachingApi/GetIntoTeachingApi.csproj
Original file line number Diff line number Diff line change
@@ -56,7 +56,7 @@
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
<PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Serilog" Version="3.1.1" />
<PackageReference Include="Serilog" Version="4.0.0" />
<PackageReference Include="Castle.Core" Version="5.1.1" />
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="7.0.18" />

Unchanged files with check annotations Beta

public string AddressPostcode { get; set; }
[SwaggerSchema(WriteOnly = true)]
public DateTime? PhoneCallScheduledAt { get; set; }
[SwaggerSchema(ReadOnly = true)]

Check warning on line 81 in GetIntoTeachingApi/Models/TeacherTrainingAdviser/TeacherTrainingAdviserSignUp.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool CanSubscribeToTeacherTrainingAdviser { get; set; }
[SwaggerSchema(ReadOnly = true)]
public int? AssignmentStatusId { get; set; }
[SwaggerSchema(ReadOnly = true)]
public Guid? MasterId { get; set; }
[SwaggerSchema(ReadOnly = true)]

Check warning on line 20 in GetIntoTeachingApi/Models/SchoolsExperience/SchoolsExperienceSignUp.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool Merged { get; set; }
[SwaggerSchema(ReadOnly = true)]
public string FullName { get; set; }
{
DateTime? ApplyLastSyncAt { get; set; }
DateTime? CrmIntegrationPausedUntil { get; set; }
bool IsApplyBackfillInProgress { get; set; }

Check warning on line 9 in GetIntoTeachingApi/Models/IAppSettings.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
bool IsCrmIntegrationPaused { get; }
}
}
Withdrawn = 222750006,
}
[JsonIgnore]

Check warning on line 25 in GetIntoTeachingApi/Models/Crm/CandidateSchoolExperience.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[EntityField("dfe_contactid", typeof(EntityReference), "contact")]
public Guid CandidateId { get; set; }
[EntityField("dfe_urn")]
public string LastName { get; set; }
public string AddressPostcode { get; set; }
public string AddressTelephone { get; set; }
public bool IsVerified { get; set; } = true;

Check warning on line 34 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
[SwaggerSchema(WriteOnly = true)]

Check warning on line 35 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool IsWalkIn { get; set; }
[SwaggerSchema(WriteOnly = true)]

Check warning on line 37 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool SubscribeToMailingList { get; set; }
[SwaggerSchema(ReadOnly = true)]

Check warning on line 39 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool AlreadySubscribedToEvents { get; set; }
[SwaggerSchema(ReadOnly = true)]

Check warning on line 41 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool AlreadySubscribedToMailingList { get; set; }
[SwaggerSchema(ReadOnly = true)]

Check warning on line 43 in GetIntoTeachingApi/Models/GetIntoTeaching/TeachingEventAddAttendee.cs

GitHub Actions / sonarcloud

Property used as input in a controller action should be nullable or annotated with the Required attribute to avoid under-posting. (https://rules.sonarsource.com/csharp/RSPEC-6964)
public bool AlreadySubscribedToTeacherTrainingAdviser { get; set; }
[JsonIgnore]