Fix heading overlap (#4261)

DFE-Digital · Oct 21, 2024 · 069bc8c · 069bc8c
1 parent 89baad8
commit 069bc8c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/app/components/content/inspiration_card_component.html.erb b/app/components/content/inspiration_card_component.html.erb
@@ -9,7 +9,9 @@
         <div class="category__nav-card__wrapper__col1">
           <div class="category__nav-card--content">
             <%= content_tag heading_tag do %>
-              <%= content_tag :span, title %>
+              <%= content_tag :span do %>
+                <%= content_tag :span, title %>
+              <% end %>
             <% end %>
             <%= tag.p(helpers.safe_html_format(description)) %>
           </div>
@@ -22,7 +24,9 @@
     <%= link_to(path, class: "link--pink") do %>
       <div class="category__nav-card--content">
         <%= content_tag heading_tag do %>
-          <%= content_tag :span, title %>
+          <%= content_tag :span do %>
+            <%= content_tag :span, title %>
+          <% end %>
         <% end %>
         <%= tag.p(helpers.safe_html_format(description)) %>
       </div>

diff --git a/app/webpacker/styles/category.scss b/app/webpacker/styles/category.scss
@@ -152,7 +152,6 @@
       h2,
       h3 {
         @extend .heading-m, .heading--margin-0;
-        line-height: 2rem;
       }
     }
   }

diff --git a/app/webpacker/styles/links-and-buttons.scss b/app/webpacker/styles/links-and-buttons.scss
@@ -37,6 +37,13 @@
     padding: .5rem;
     background: $backgroundColor;
     box-shadow: 0 0 0 $backgroundColor, -0 0 0 $backgroundColor;
+
+    span {
+      position: relative;
+      background: none;
+      padding: 0;
+      box-shadow: none;
+    }
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -152,7 +152,6 @@ @@
           h2,
           h3 {
             @extend .heading-m, .heading--margin-0;
-            line-height: 2rem;
           }
         }
       }
@@ Expand Down @@