Enable big query config in aks service #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vipin-dfe
force-pushed
the
enable_dfe_analytics
branch
from
f8883ab to
82c47ec
Compare
vipin-dfe
force-pushed
the
enable_dfe_analytics
branch
from
82c47ec to
cb53f0c
Compare
saliceti
reviewed
Dec 6, 2024
saliceti
reviewed
Dec 6, 2024
saliceti
reviewed
Dec 6, 2024
saliceti
reviewed
Dec 6, 2024
saliceti
reviewed
Dec 6, 2024
vipin-dfe
force-pushed
the
enable_dfe_analytics
branch
from
1844bc8 to
4ee7f98
Compare
vipin-dfe
force-pushed
the
enable_dfe_analytics
branch
from
4ee7f98 to
ea45145
Compare
saliceti
reviewed
Dec 9, 2024
| @@ -6,8 +6,5 @@ VWO_ID=713156 | |||
| SKYLIGHT_ENV=dev | |||
| FAST_IMAGE_TIMEOUT=0.25 | |||
| SIZE_IMAGES=1 | |||
| BIGQUERY_TABLE_NAME=events | |||
There was a problem hiding this comment.
Shouldn't they be removed from the other .env files?
vipin-dfe
force-pushed
the
enable_dfe_analytics
branch
from
3ed29aa to
9137ad0
Compare
saliceti
reviewed
Dec 9, 2024
terraform/aks/variables.tf
Outdated
| default = false | ||
| } | ||
| variable "dataset_name" { | ||
| description = "dfe analytics dataset name in Google Bigquery. If not specified, a new one will be created" |
There was a problem hiding this comment.
If not specified, a new one will be created
No we won't create a new one
|
|
Review app deployed to https://get-into-teaching-app-review-4299.test.teacherservices.cloud |
saliceti
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/5YFXDRps
Context
All services will be migrated to the workload identity federation for improved security.
Changes proposed in this pull request
Enable the analytics module for get into teaching app
Guidance to review
Events should be published for review apps into big query