Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back Ruby 3.3 to Ruby 3.1 (again) #4401

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

martyn-w
Copy link
Contributor

@martyn-w martyn-w commented Dec 3, 2024

Trello card

Roll back of Upgrade to Ruby 3.3

Context

Upgrading to Ruby 3.3 has broken the Selenium Javascript driver, which breaks the integration tests (and webchat feature tests)

Changes proposed in this pull request

This rolls back the upgrade, for re-consideration in the new year.

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code docker Pull requests that update Docker code test Config labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

@github-actions github-actions bot added the Review label Dec 3, 2024
@martyn-w martyn-w enabled auto-merge (squash) December 4, 2024 09:08
Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@martyn-w martyn-w merged commit 41bf0cd into master Dec 4, 2024
28 checks passed
@martyn-w martyn-w deleted the rollback-ruby3-3-again branch December 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config docker Pull requests that update Docker code Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants