-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is it like being a teacher page #4405
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for you! Let me know if easier to chat through them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! I've put a couple of comments below.
app/views/content/life-as-a-teacher/teaching-as-a-career/_categories.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments below! You'll also need to remove the current 'day in a life of a teacher' page and set up a redirect. I can walk you through how to do this if you need any support!
app/views/content/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher.md
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
...ntent/life-as-a-teacher/teaching-as-a-career/what-its-like-to-be-a-teacher/_article.html.erb
Outdated
Show resolved
Hide resolved
Review app deployed to https://get-into-teaching-app-review-4405.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
https://trello.com/c/fo8cclK2
GIT users need to feel inspired to teach and reassured that teaching is a viable career for them
There is a content gap. We don’t currently provide much information to users about the reality and challenges of teaching.