Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is it like being a teacher page #4405

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Dec 5, 2024

https://trello.com/c/fo8cclK2

GIT users need to feel inspired to teach and reassured that teaching is a viable career for them

There is a content gap. We don’t currently provide much information to users about the reality and challenges of teaching.

@github-actions github-actions bot added the content Content changes label Dec 5, 2024
@github-actions github-actions bot added the Review label Dec 5, 2024
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for you! Let me know if easier to chat through them.

app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
app/views/content/a-day-in-the-life-of-a-teacher.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Dec 9, 2024
Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! I've put a couple of comments below.

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments below! You'll also need to remove the current 'day in a life of a teacher' page and set up a redirect. I can walk you through how to do this if you need any support!

Copy link

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants