Routes Wizard #4411
Merged
Routes Wizard #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
* recreated results box component and associated styling * added spec test for results box component * added results box to completed page of routes wizard * adjusted media query to improve responsiveness on mobile/tablet * Fixed spacing * removed results box from completed page of routes wizard * fixed indenting on results box css file --------- Co-authored-by: Spencer Dixon <[email protected]>
spencerldixon
changed the title
* WIP routes wizard logic * Completed matching logic for each route into teaching * Lint and exclude from orphan variables check * Ammend logic to support multiple answers to a question * WIP move logic to routes class * WIP adding tests * WIP adding tests * Add results box component * Add basic layout to completed page and add results boxes * Remove substitute values from most fields in results box * Amend routes mapping * Added not yet answers for routes mapping * Remove two routes
* WIP routes wizard logic * Completed matching logic for each route into teaching * Lint and exclude from orphan variables check * Ammend logic to support multiple answers to a question * WIP move logic to routes class * WIP adding tests * WIP adding tests * Add results box component * Add basic layout to completed page and add results boxes * Remove substitute values from most fields in results box * Amend routes mapping * Added not yet answers for routes mapping * WIP adding page layout * Added mailing list form component * Change case-when to hash to satisfy rubocop * Swap order of privacy policy and next step button * Improve error messaging and spacing of results cards * Add start page and extra spacing to bottom of mailer form submit button * Linting * Update app/views/routes_into_teaching/steps/completed.html.erb Co-authored-by: Gemma Dallman <[email protected]> * Stylelint fixes to results box css * Added default heading tag to QuoteWithImageComponent and changed ResultsBoxComponent to render a h3 * Fix renaming of quote with image component attribute --------- Co-authored-by: Gemma Dallman <[email protected]>
* Add cta component to routes wizard results box * Fix responsiveness of cta circle icon
…izard-results-pages
### Trello card https://trello.com/c/e2pnl2Bs/7297-test-the-routes-wizard ### Context ### Changes proposed in this pull request ### Guidance to review
Co-authored-by: Gemma Dallman <[email protected]>
Update routes content
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
martyn-w
reviewed
Jan 28, 2025
* Add back button on first step * Remove non uk expander component * Add aria hidden true label to hr separators in results box component
martyn-w
reviewed
Jan 28, 2025
| <%= f.govuk_text_field :first_name, autocomplete: "given-name" %> | ||
| <%= f.govuk_text_field :last_name, autocomplete: "family-name" %> | ||
| <%= f.govuk_email_field :email, autocomplete: "email" %> | ||
| <%= f.hidden_field :channel_id, value: params[:channel] || f.object&.channel_id.presence %> |
There was a problem hiding this comment.
NB these parameters will need to be updated once PR #4507 is merged in
Expand QTS acronym and remove full stop from routes wizard
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
gemmadallmandfe
previously approved these changes
Jan 28, 2025
Amend AO wording on routes wizard
emmaachesongray
temporarily deployed
to
review
GitHub Actions
Inactive
|
Review app deployed to https://get-into-teaching-app-review-4411.test.teacherservices.cloud |
|
gemmadallmandfe
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/nRCbhphO/7084-build-question-pages-and-initial-output-for-routes-wizard?filter=member:spencerldixon
Context
We want to ask candidates three simple questions and then display appropriate route information depending on their answers
We want to build the three question pages and render the answers on a results page as a first step - (adding logic to determine the route(s) to be displayed will be done in a later ticket)
Changes proposed in this pull request
/routes-into-teachingpathGuidance to review