-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results box component - Routes Wizard #4412
Open
sarahcrack
wants to merge
8
commits into
master
Choose a base branch
from
results-box-component
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormat and styling for inspo/testing - work in progress
…w for toggling of border colours and title
…ent for cta as placeholder - to be replaced when new ctalinks component has been built
…to check for no title
Quality Gate passedIssues Measures |
Review app deployed to https://get-into-teaching-app-review-4412.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/isyaeq4w/7085-build-results-box-component-for-routes-wizard
Context
We are introducing a new routes wizard and to be able to display results for candidates. We want to build a new results box component that can be used to display route wizard results.
Changes proposed in this pull request
Created a
ResultsBoxComponent
that can be used for displaying results to users when using the routes wizard. The component can be used to display results within a grey border as well as the 'Most popular route' with title and a yellow border.Guidance to review
LinkAsButton
component as a placeholder for the CTA (this will be changed when the new CTA link component has been built).title
andborder_color
to see the grey 'default' box):