Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build persmissions #4418

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix CI build persmissions #4418

merged 1 commit into from
Dec 10, 2024

Conversation

vipin-dfe
Copy link
Contributor

@vipin-dfe vipin-dfe commented Dec 10, 2024

Trello card

https://trello.com/c/5YFXDRps/2117-git-migrate-to-gcp-wif

Context

Jobs inside the workflow fail due to lack of permissions.

Changes proposed in this pull request

Remove permission from individual jobs in a workflow. Setting permissions on individual jobs overrides the permissions set on the workflow level.

Guidance to review

Verify if all the jobs have the same permissions as defined on the workflow level

Remove permission from individual jobs in a workflow. Setting
permissions on individual jobs overrides the permissions set on the
workflow level.
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link

@vipin-dfe vipin-dfe merged commit c4c7179 into master Dec 10, 2024
29 checks passed
@vipin-dfe vipin-dfe deleted the fix_ci_permissions branch December 10, 2024 12:12
@vipin-dfe
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants