Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mailing list start page #4422

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Update mailing list start page #4422

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98432db
Update mailing list content
emmaachesongray Dec 10, 2024
0ee1ee4
update spec test
emmaachesongray Dec 10, 2024
3adae5a
spec
emmaachesongray Dec 10, 2024
caaa387
Apply suggestions from code review
emmaachesongray Dec 10, 2024
67f839b
Update app/views/mailing_list/steps/_name.html.erb
emmaachesongray Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions app/views/mailing_list/steps/_name.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,14 @@
<h1>Get personalised guidance on teacher training in your inbox</h1>
<h1>Free personalised teacher training guidance</h1>

<p>
If you're interested in training to teach in primary, secondary and special schools in England, get everything you need to know to start a career in teaching.
Discover everything you need to know to start a teaching career in England, sent straight to your inbox. Personalised to you, we'll send you the latest information as well as advice and support.
</p>
gemmadallmandfe marked this conversation as resolved.
Show resolved Hide resolved

<p>
Find out how to get:
</p>

<ul>
<li> a taste of life in the classroom</li>
<li> funding to train</li>
<li> one-to-one support</li>
<li> advice from trainees or recently qualified teachers</li>
</ul>

<%= f.govuk_text_field :first_name, width: 'two-thirds', autocomplete: "given-name" %>
<%= f.govuk_text_field :last_name, width: 'two-thirds', autocomplete: "family-name" %>
<%= f.govuk_email_field :email, width: 'two-thirds', autocomplete: "email" %>
<%= f.hidden_field :channel_id, value: params[:channel] || f.object.channel_id %>
<%= f.hidden_field :sub_channel_id, value: params[:sub_channel] || f.object.sub_channel_id %>
<%= f.hidden_field :accepted_policy_id, value: f.object.latest_privacy_policy.id %>

<p>Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>.</p>

<p>Our privacy notice explains how we use your personal data. It's important you read this before signing up to receive emails.</p>
<p>Your details are protected under the terms of our <%= link_to("privacy notice (opens in new tab)", privacy_policy_path(id: f.object.latest_privacy_policy.id), { target: :blank }) %>. Our privacy notice explains how we use your personal data. It's important you read this before signing up to receive emails.</p>
2 changes: 1 addition & 1 deletion docs/sign-up-journeys.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ There are multiple different sign up journeys available on the Get into Teaching

```mermaid
graph TD;
name[Get personalised guidance on teacher training in your inbox] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?]
name[Free personalised teacher training guidanceer training in your inbox] -- Doesn't exist in CRM --> returning_teacher[Are you already qualified to teach?]
emmaachesongray marked this conversation as resolved.
Show resolved Hide resolved
name -- Exists in CRM --> authenticate[You're already registered with us]

returning_teacher -- Yes --> already_qualified[We're sorry, but our emails are for people who are not already qualified to teach]
Expand Down
22 changes: 11 additions & 11 deletions spec/features/mailing_list_wizard_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

expect(page).to have_title(mailing_list_page_title)

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand Down Expand Up @@ -54,7 +54,7 @@
channel_id = channels.first.id
visit mailing_list_steps_path({ id: :name, channel: channel_id, sub_channel: sub_channel_id })

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
# Error to ensure channel/sub-channel persists over page reload.
click_on "Next step"
expect(page).to have_text("Enter your full email address")
Expand Down Expand Up @@ -96,7 +96,7 @@
channel_id = channels.first.id
visit mailing_list_steps_path({ id: :name, channel: channel_id, sub_channel: sub_channel_id })

expect(page).to have_text("Get personalised guidance on teacher training in your inbox")
expect(page).to have_text("Free personalised teacher training guidance")
fill_in_name_step
click_on "Next step"

Expand Down Expand Up @@ -135,7 +135,7 @@

visit mailing_list_steps_path({ id: :name, channel: "invalid", sub_channel: sub_channel_id })

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidancee"
emmaachesongray marked this conversation as resolved.
Show resolved Hide resolved
fill_in_name_step
click_on "Next step"

Expand Down Expand Up @@ -179,7 +179,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step(first_name: first_name)
click_on "Next step"

Expand Down Expand Up @@ -219,7 +219,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand All @@ -243,7 +243,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand Down Expand Up @@ -274,7 +274,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand All @@ -298,7 +298,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand Down Expand Up @@ -378,7 +378,7 @@

visit mailing_list_steps_path

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step
click_on "Next step"

Expand All @@ -395,7 +395,7 @@
allow_any_instance_of(GetIntoTeachingApiClient::CandidatesApi).to \
receive(:create_candidate_access_token).and_raise(GetIntoTeachingApiClient::ApiError)

expect(page).to have_text "Get personalised guidance on teacher training in your inbox"
expect(page).to have_text "Free personalised teacher training guidance"
fill_in_name_step(email: "[email protected]")
click_on "Next step"

Expand Down
Loading