Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace adviser promos on non-uk and steps page #4424

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Replace adviser promos on non-uk and steps page #4424

merged 1 commit into from
Dec 11, 2024

Conversation

emmaachesongray
Copy link
Contributor

Trello card

https://trello.com/c/3Bweg0NG/7061

Context

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code content Content changes labels Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
12 New issues
10 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Review app deployed to https://get-into-teaching-app-review-4424.test.teacherservices.cloud

gemmadallmandfe
gemmadallmandfe approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@emmaachesongray emmaachesongray changed the title Replace remaining adviser promos Replace adviser promos on non-uk and steps page Dec 11, 2024
martyn-w
martyn-w approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM from tech perspective; please get a content review too

@emmaachesongray emmaachesongray merged commit d9751b3 into master Dec 11, 2024
29 checks passed
@emmaachesongray emmaachesongray deleted the replace-adviser-promo-non-uk branch December 11, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemmadallmandfe gemmadallmandfe gemmadallmandfe approved these changes

@martyn-w martyn-w martyn-w approved these changes

Assignees
No one assigned
Labels
content Content changes Review ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmaachesongray @martyn-w @gemmadallmandfe