Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace adviser promo on subject pages #4428

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

emmaachesongray
Copy link
Contributor

@emmaachesongray emmaachesongray commented Dec 11, 2024

Trello card

https://trello.com/c/3Bweg0NG/7061

Context

Adviser promo can now be used as a component.

Changes proposed in this pull request

Replace adviser promo partial files with components on the subject pages.

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code test content Content changes labels Dec 11, 2024
Copy link

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM from tech perspective; please get a content review too

@emmaachesongray emmaachesongray merged commit 7da5116 into master Dec 11, 2024
29 checks passed
@emmaachesongray emmaachesongray deleted the update-adviser-promo-subject-pages branch December 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants