Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds width to image blocks to prevent collapse with flexbox #4430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spencerldixon
Copy link
Collaborator

Trello card

https://trello.com/c/Jd9HvLCS/6811-phase-5-repurpose-navigation-component-for-life-as-a-teacher-section?filter=member:spencerldixon

Context

When collapsing the page between tablet and mobile breakpoints, the content overlaps the footer.

Changes proposed in this pull request

  • Adds width to image-blocks class to ensure that when they collapse they do not overflow

Copy link

@gemmadallmandfe
Copy link
Contributor

@spencerldixon This looks better from an initial look at the review app but I think we should probably hold fire and deploy post code freeze so we can do a proper test

In the meantime, can you confirm which other components are affected by this styling change?

I've looked at the nav directory, the home page (directory and CTA blocks), the callback completion page (can't test events completion page as no event to test with!) and the 404 page - plus looked at various other template pages on the site

@jenhadfield-dfe @martyn-w Can you also review (but for deploy on 2 Jan!)

@spencerldixon
Copy link
Collaborator Author

@gemmadallmandfe this fix is scoped to image-blocks only so shouldn't affect anything except the blocks on the homepage and the life as a teacher page.

@jenhadfield-dfe
Copy link
Contributor

looks good to me

Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@martyn-w
Copy link
Contributor

On wide screens the image blocks overflow the righthand margin. Is this OK?

Screenshot 2024-12-17 at 09 12 00

@jenhadfield-dfe
Copy link
Contributor

On wide screens the image blocks overflow the righthand margin. Is this OK?

Screenshot 2024-12-17 at 09 12 00

doesn't do this for me on chrome, is it displaying differently in different browsers?

@gemmadallmandfe
Copy link
Contributor

I can replicate this in Chrome
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants