-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds width to image blocks to prevent collapse with flexbox #4430
base: master
Are you sure you want to change the base?
Conversation
Review app deployed to https://get-into-teaching-app-review-4430.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
@spencerldixon This looks better from an initial look at the review app but I think we should probably hold fire and deploy post code freeze so we can do a proper test In the meantime, can you confirm which other components are affected by this styling change? I've looked at the nav directory, the home page (directory and CTA blocks), the callback completion page (can't test events completion page as no event to test with!) and the 404 page - plus looked at various other template pages on the site @jenhadfield-dfe @martyn-w Can you also review (but for deploy on 2 Jan!) |
@gemmadallmandfe this fix is scoped to |
looks good to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Trello card
https://trello.com/c/Jd9HvLCS/6811-phase-5-repurpose-navigation-component-for-life-as-a-teacher-section?filter=member:spencerldixon
Context
When collapsing the page between tablet and mobile breakpoints, the content overlaps the footer.
Changes proposed in this pull request
image-blocks
class to ensure that when they collapse they do not overflow