Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcode content on the mailing list #4433

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

emmaachesongray
Copy link
Contributor

@emmaachesongray emmaachesongray commented Dec 12, 2024

Trello card

https://trello.com/c/ML8z1D9w/7053

Context

We ran user research on the mailing list sign up, and changed some of the content on the postcode step.

Changes proposed in this pull request

Update the content below the question on the postcode page.

Guidance to review

@github-actions github-actions bot added ruby Pull requests that update Ruby code Config labels Dec 12, 2024
Copy link
Collaborator

@Sarah-DfE Sarah-DfE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of teeny comments/suggestions @emmaachesongray

app/views/mailing_list/steps/_postcode.html.erb Outdated Show resolved Hide resolved
app/views/mailing_list/steps/_postcode.html.erb Outdated Show resolved Hide resolved
martyn-w
martyn-w previously approved these changes Dec 12, 2024
Copy link
Contributor

@martyn-w martyn-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM (from tech perspective) - please get a content review too

@gemmadallmandfe
Copy link
Contributor

gemmadallmandfe commented Dec 16, 2024

@emmaachesongray In the designs, we changed the question to What's your UK postcode (optional)? - have we moved away from this now?

Copy link

Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Review ruby Pull requests that update Ruby code test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants