Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTA links component #4448

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

CTA links component #4448

wants to merge 9 commits into from

Conversation

sarahcrack
Copy link
Collaborator

@sarahcrack sarahcrack commented Dec 20, 2024

Trello card

https://trello.com/c/4KTcG2Y0/7095-build-cta-links-component-for-use-in-routes-wizard-and-around-site

Context

User research found that candidates thought that there were a lot of links on the page but generally said that it was not overwhelming. The green CTA is very powerful – Candidates said that this is what they would select first because they are more “important” and “inviting”. We want to use a green CTA link around the site.

Changes proposed in this pull request

  • Using CSS/Font Awesome icon, created an arrow to fit within a green circle 'button' that sits next to an anchor link.
  • Created a new partial that can be used to render the link with arrow circle icon; link_text and href can be passed into the partial to display the desired information/link.

Guidance to review

  • You can render the green CTA arrow link using the following code:
    <%= render 'content/shared/links_and_buttons/cta_circle_button_link', cta_link_text: "Steps to become a teacher", href: "/steps-to-become-a-teacher" %>

@github-actions github-actions bot added ruby Pull requests that update Ruby code Style content Content changes labels Dec 20, 2024
…e responsivess for the size of button and arrow inside
Copy link

github-actions bot commented Jan 7, 2025

@sarahcrack sarahcrack marked this pull request as ready for review January 8, 2025 12:19
Copy link
Collaborator

@spencerldixon spencerldixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor tweaks here

It looks pretty good on the long sentence test, wraps nicely, but the icon will be in the middle of the sentence. I'm not sure if it would look better aligning to the top or if that throws things out when it's a single sentence.

Screenshot 2025-01-08 at 15 25 36

It would also be nice to have the icon enter the hover state when you hover over the text. This works well when you hover the icon atm and both the icon and the text enter their hover states, but not the other way around.

Also there is a bit of white around the icon on focus state. I see you're setting a white background which probably isn't needed so removing this should fix it.

Screenshot 2025-01-08 at 15 25 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review ruby Pull requests that update Ruby code Style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants