-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTA links component #4448
base: master
Are you sure you want to change the base?
CTA links component #4448
Conversation
…evant link text and href
…s - work in progress. Currently rendering link on homepage
…e responsivess for the size of button and arrow inside
…is within black box on focus
Review app deployed to https://get-into-teaching-app-review-4448.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor tweaks here
It looks pretty good on the long sentence test, wraps nicely, but the icon will be in the middle of the sentence. I'm not sure if it would look better aligning to the top or if that throws things out when it's a single sentence.
It would also be nice to have the icon enter the hover state when you hover over the text. This works well when you hover the icon atm and both the icon and the text enter their hover states, but not the other way around.
Also there is a bit of white around the icon on focus state. I see you're setting a white background which probably isn't needed so removing this should fix it.
Trello card
https://trello.com/c/4KTcG2Y0/7095-build-cta-links-component-for-use-in-routes-wizard-and-around-site
Context
User research found that candidates thought that there were a lot of links on the page but generally said that it was not overwhelming. The green CTA is very powerful – Candidates said that this is what they would select first because they are more “important” and “inviting”. We want to use a green CTA link around the site.
Changes proposed in this pull request
link_text
andhref
can be passed into the partial to display the desired information/link.Guidance to review
<%= render 'content/shared/links_and_buttons/cta_circle_button_link', cta_link_text: "Steps to become a teacher", href: "/steps-to-become-a-teacher" %>