-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ukraine inset added to the non-uk teachers pages #4452
Conversation
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Outdated
Show resolved
Hide resolved
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Gemma Dallman <[email protected]>
title: moving to the UK | ||
text: |- | ||
<p> | ||
Check what you need to do before you travel and after you arrive <a href="https://www.gov.uk/guidance/move-to-the-uk-if-youre-from-ukraine">if you're moving to the UK from Ukraine</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback for this content as on the other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Emma, get what you're saying, but going to leave as there's separate guidance for planning to move and what to do when you have moved
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Show resolved
Hide resolved
link_url: /non-uk-teachers/visas-for-non-uk-trainees | ||
ukraine-visas: | ||
header: Ukraine citizens | ||
title: visa support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: visa support | |
title: help with visas |
title: moving to the UK | ||
text: |- | ||
<p> | ||
Check what you need to do before you travel and after you arrive <a href="https://www.gov.uk/guidance/move-to-the-uk-if-youre-from-ukraine">if you're moving to the UK from Ukraine</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Emma, get what you're saying, but going to leave as there's separate guidance for planning to move and what to do when you have moved
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Outdated
Show resolved
Hide resolved
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Outdated
Show resolved
Hide resolved
app/views/content/non-uk-teachers/teach-in-england-if-you-trained-overseas.md
Show resolved
Hide resolved
Review app deployed to https://get-into-teaching-app-review-4452.test.teacherservices.cloud |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Trello card
https://trello.com/c/qb7ZCW3E/6896-delete-ukraine-page-and-redirect-to-non-uk-citizens-page
Context
Included Ukraine inset in the non-UK teachers pages
Also included the visas page in the sub-category page as part of this PR
Changes proposed in this pull request
Guidance to review