Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ukraine inset added to the non-uk teachers pages #4452

Merged
merged 10 commits into from
Jan 9, 2025

Conversation

Sarah-DfE
Copy link
Collaborator

Trello card

https://trello.com/c/qb7ZCW3E/6896-delete-ukraine-page-and-redirect-to-non-uk-citizens-page

Context

Included Ukraine inset in the non-UK teachers pages

Also included the visas page in the sub-category page as part of this PR

Changes proposed in this pull request

Guidance to review

@github-actions github-actions bot added the content Content changes label Dec 24, 2024
@Sarah-DfE Sarah-DfE changed the title added a link to the teacher visas page to the subcategory page ukraine inset added to the non-uk teachers pages Dec 24, 2024
Copy link
Contributor

@gemmadallmandfe gemmadallmandfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Co-authored-by: Gemma Dallman <[email protected]>
title: moving to the UK
text: |-
<p>
Check what you need to do before you travel and after you arrive <a href="https://www.gov.uk/guidance/move-to-the-uk-if-youre-from-ukraine">if you're moving to the UK from Ukraine</a>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback for this content as on the other PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emma, get what you're saying, but going to leave as there's separate guidance for planning to move and what to do when you have moved

link_url: /non-uk-teachers/visas-for-non-uk-trainees
ukraine-visas:
header: Ukraine citizens
title: visa support
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: visa support
title: help with visas

title: moving to the UK
text: |-
<p>
Check what you need to do before you travel and after you arrive <a href="https://www.gov.uk/guidance/move-to-the-uk-if-youre-from-ukraine">if you're moving to the UK from Ukraine</a>.</p>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Emma, get what you're saying, but going to leave as there's separate guidance for planning to move and what to do when you have moved

Copy link

github-actions bot commented Jan 7, 2025

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sarah-DfE Sarah-DfE merged commit 869b692 into master Jan 9, 2025
27 checks passed
@Sarah-DfE Sarah-DfE deleted the ukraine-insets-on-non-uk-teachers-pages branch January 9, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content changes Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants