Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a partial guidance #4465

Merged
merged 4 commits into from
Jan 8, 2025
Merged

create a partial guidance #4465

merged 4 commits into from
Jan 8, 2025

Conversation

joegibb
Copy link
Collaborator

@joegibb joegibb commented Jan 2, 2025

https://trello.com/c/JlFdnjn5

Creating guidance on how and when to use partials

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Only thing to add might be about using frontmatter in partials?

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

teeny comment, but otherwise looks good to go :)

docs/content.md Outdated Show resolved Hide resolved
Co-authored-by: emmaachesongray <[email protected]>
Copy link

github-actions bot commented Jan 7, 2025

Copy link
Contributor

@emmaachesongray emmaachesongray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joegibb joegibb merged commit faeb475 into master Jan 8, 2025
27 checks passed
@joegibb joegibb deleted the create-guidance-for-partials branch January 8, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants